[WIP] Simulator backends refactoring #319
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ror matrices from cpp simulator to python code - qiskit_simulator now only takes a U_error matrix - parameters ‘calibration_error’, ‘detuning_error’, ‘zz_error’ for CX and X90 gates are now converted to U_error matrices in python before being passed to simulator - fixed incorrect matrix used for CX calibration errors - added check in C++ code that U_error is unitary - added python unit tests to test U_error building matrices - fixed directory change in makefile
Modification is so that pretty printing of arrays doesn’t add new lines.
- Encapsulated multi-partite qubit state vector updates in a QubitVector class - Added TensorIndex class used for indexing in the QubitVector class. - Reworked ideal_backend and qubit_backend to use QubitVector methods - removed ability to display final and saved quantum states - added “snapshot” instruction and added ability to display snapshots of quantum state
…iskit-sdk-py into chriseclectic-simulator-refactor
Fixed missing parentheses for some snapshot statements Added auto check to makefile for GCC7 compiler on macOS
3 tasks
|
Closing to add new WIP pull request of rebased branched in #351 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WIP on refactoring simulator backends (related to issues #281, and #314).
It's still in progress but I'm putting the WIP here so @ajavadia and others can push to my fork.
Types of changes
Current changes
tensor_index.hpp) for multi-partite qubit vector indexingqubit_vector.hpp) for multi-partite qubit vector algebraQubitVectorclass and methods instead ofstd::vector.savecommand (usesnapshotinstead)snapshotinstead)Still TODO: