catch deprecated basis specification #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some devices would return a basis of the form 'SU2+CNOT'. If there are no commas in basis string it will be replaced with u1,u2,u3,cx.id and a warning will be logged.
diego-plan9
approved these changes
Dec 21, 2017
taalexander
pushed a commit
to taalexander/qiskit-terra
that referenced
this pull request
May 2, 2019
* Start release notes for Terra release 0.8 This commit starts the release notes for the Terra 0.8 release. They're still a WIP, this is just the start and more details need to be flushed out before the release. * Fix lint and small tweaks
taalexander
pushed a commit
to taalexander/qiskit-terra
that referenced
this pull request
May 2, 2019
This commit is a continuation of the release notes added in Qiskit#211. The notes there weren't complete and still need to be flushed out more. This commit starts off where that left off.
lia-approves
pushed a commit
to edasgupta/qiskit-terra
that referenced
this pull request
Jul 30, 2019
Some devices would return a basis of the form 'SU2+CNOT'. If there are no commas in basis string it will be replaced with u1,u2,u3,cx.id and a warning will be logged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some devices would return a basis of the form 'SU2+CNOT'.
If there are no commas in basis string it will be replaced
with u1,u2,u3,cx.id and a warning will be logged.
Description
Motivation and Context
Without this change the unroller just uses U and CX gates when it encounters this unrecognized basis specification. When all remote backends adopt the new basis specification this code can probably be elimintated, however, in the future it may be better for the unroller to throw an exception if it encounters such an error.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: