minor revision in _dagbackend.py #172
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adjs
referenced
this pull request
Dec 3, 2017
|
Thank you for catching this! Instead of changing the call from sym() to real() in the dagbackend, I think the expression node objects need to all have sym() methods. The same problem occurs with unary operators too, eg. writing "u1(-2.7) q[0];" (see the "add sym() to Prefix()" commit in PR #171). We should add these examples as tests. |
Closed
diego-plan9
pushed a commit
to awcross1/qiskit-terra
that referenced
this pull request
Dec 5, 2017
diego-plan9
pushed a commit
to awcross1/qiskit-terra
that referenced
this pull request
Dec 12, 2017
diego-plan9
pushed a commit
that referenced
this pull request
Dec 12, 2017
* optimize_1q_gates behavior change: remove u1(2*pi). Address issue #159. Modifications to use of sympy in optimize_1q_gates. Updated tests. * Remove comment. * Add sym() method to Prefix(). Fixes a problem with sympy integration for negated parameters. * Remove print(). * Add sym() to binaryop. * new test to check the bug in #172 * doc * Linting and style fixes * Fix test_mapper test that depends on Python vers. Modify `test_math_domain_error` in order to expect different results depending on the version of Python. This is a work-around to allow the test to pass, but should be handled higher up. * moving toffoli_gate test to test_quantumprogram * removing not necessary N () to improve performance * add new tests. * add corresponding test qasm files. * tests and corrections. * Restyle test_mapper tests, update example qasms * Allow test_mapper to compare QASM for Python 3.5 Revise "test_optimize_1q_gates_issue159" comparing the output of the compilation with two similar expected outputs.
taalexander
pushed a commit
to taalexander/qiskit-terra
that referenced
this pull request
May 2, 2019
lia-approves
pushed a commit
to edasgupta/qiskit-terra
that referenced
this pull request
Jul 30, 2019
* optimize_1q_gates behavior change: remove u1(2*pi). Address issue Qiskit#159. Modifications to use of sympy in optimize_1q_gates. Updated tests. * Remove comment. * Add sym() method to Prefix(). Fixes a problem with sympy integration for negated parameters. * Remove print(). * Add sym() to binaryop. * new test to check the bug in Qiskit#172 * doc * Linting and style fixes * Fix test_mapper test that depends on Python vers. Modify `test_math_domain_error` in order to expect different results depending on the version of Python. This is a work-around to allow the test to pass, but should be handled higher up. * moving toffoli_gate test to test_quantumprogram * removing not necessary N () to improve performance * add new tests. * add corresponding test qasm files. * tests and corrections. * Restyle test_mapper tests, update example qasms * Allow test_mapper to compare QASM for Python 3.5 Revise "test_optimize_1q_gates_issue159" comparing the output of the compilation with two similar expected outputs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After #167. When I run the attached file I get “AttributeError: 'BinaryOp' object has no attribute 'sym'”. I reverted the file that originates the error.
bug.py.txt
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: