get rid of float in favor of sympy #167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awcross1
approved these changes
Nov 30, 2017
taalexander
pushed a commit
to taalexander/qiskit-terra
that referenced
this pull request
May 2, 2019
* Bump qiskit-terra version There was a new qiskit-terra bugfix release today to fix an error in the BasicAer python simulator. Bump the requirement for qiskit-terra to use this. * Add changelog
lia-approves
pushed a commit
to edasgupta/qiskit-terra
that referenced
this pull request
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current code is full of complicated semi-zero checks and flouting point errors because the use of floats. Since they are everywhere, I will take sometime to get rid of them. Comments? -> #158
This PR is a fix on #165.
Motivation and Context
This PR is an initial attempt to get rid of floats. Although, more work is needed. Probably the best way is to merge the slowly instead that have a huge PR.
How Has This Been Tested?
All the current tests pass.
The test
test.python.test_quantumprogram.TestQuantumProgram.test_get_compiled_qasmwas modified because it counted the amount of chars in resulting QASM. Values like3.14...now arepi.Types of changes