Skip to content

get rid of float in favor of sympy #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 25 commits into from
Closed

get rid of float in favor of sympy #165

wants to merge 25 commits into from

Conversation

1ucian0
Copy link
Member

@1ucian0 1ucian0 commented Nov 28, 2017

Description

The current code is full of complicated semi-zero checks and flouting point errors because the use of floats. Since they are everywhere, I will take sometime to get rid of them. Comments? -> #158

Motivation and Context

This PR is an initial attempt to get rid of floats. Although, more work is needed. Probably the best way is to merge the slowly instead that have a huge PR.

How Has This Been Tested?

All the current tests pass.
The test test.python.test_quantumprogram.TestQuantumProgram.test_get_compiled_qasm was modified because it counted the amount of chars in resulting QASM. Values like 3.14... now are pi.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

1ucian0 added 25 commits November 15, 2017 17:15
@1ucian0
tests for the mapper
822fd31
@1ucian0
ignore pycharm dir
9fe8475
@1ucian0
test issue 111
f07d051
@1ucian0
fixing #111
0b5fcca
@1ucian0
assert in test_issue_111
9728cff
@1ucian0
float -> N
0077e13
@1ucian0
requirements: sympy>=1.0
34e5a36
@1ucian0
requirements: sympy>=1.0
61b0bd7
@1ucian0
setup: sympy>=1.0
667b29a
@1ucian0
test description
f5eb329
@1ucian0
qasm files renamed
0da5d58
@1ucian0
Merge branch 'master' into 111
b64ec64
@1ucian0
Merge branch '111' of github.com:lbello/qiskit-sdk-py into 111
ced2e46
@1ucian0
extending userspace with inverse trigonometric functions
8b6ce2b
@1ucian0
merge
0b44b72
@1ucian0
convert in float before pushing values in DAG
edce35a
@1ucian0
remove math from mapping.py
71dedb3
@1ucian0
no floats arround + check
2e7661a
@1ucian0
epsilon comparisons are not needed anymore
6a2b8dd
@1ucian0
removing math from parser
326e36d
@1ucian0
not every epsilon comparison can be removed, since there are some flo…
cf1c8d4 
…ats still around
@1ucian0
ast with symbols in the nodes
8a686c0
@1ucian0
u2(0.0,3.141592653589793) -> u2(0,pi)
a0ae7f7
@1ucian0
Merge branch 'master' of https://github.com/QISKit/qiskit-sdk-py
b130e96
@1ucian0
Merge branch 'master' into 111
222cd41
@1ucian0 1ucian0 closed this Nov 28, 2017
@1ucian0 1ucian0 mentioned this pull request Nov 28, 2017
Merged
1 task
taalexander pushed a commit to taalexander/qiskit-terra that referenced this pull request May 2, 2019
@derivation
publish Ignis docs (Qiskit#165)
d848213 
* publish Ignis docs

* add instructions for Ignis

* change order of elements in global ToC

* getting started must wait til notebooks move

* Update docs/install.rst

Co-Authored-By: derivation <paul.kassebaum@ibm.com>

* Update docs/install.rst

Co-Authored-By: derivation <paul.kassebaum@ibm.com>

* embolden UI directions

* qiskit-ignis calls not needed for install
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@1ucian0