-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Add support for parameterized gates to the Target C API #14832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 16809769056Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a straightforward addition, I just have one minor comment.
00d71df
to
68480dc
Compare
This commit expands the QkTarget API to support taking parameterized gates that accept any angle value. Previously, this was not possible because representing these gates internally in the target depended on Python. That restriction has been removed with Qiskit#14799 and we can now expose this functionality to C. This is a necessary component for being able to build targets for current devices since they all typically expose at least one gate that takes an arbitrary angle. Fixes Qiskit#14704
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more docs comments and we're good to go.
releasenotes/notes/parameterized_target_c-9c9a4ad2915c2348.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Raynel Sanchez <87539502+raynelfss@users.noreply.github.com>
Summary
This commit expands the QkTarget API to support taking parameterized
gates that accept any angle value. Previously, this was not possible
because representing these gates internally in the target depended on
Python. That restriction has been removed with #14799 and we can now
expose this functionality to C. This is a necessary component for being
able to build targets for current devices since they all typically
expose at least one gate that takes an arbitrary angle.
Details and comments
Fixes #14704
This commit is based on #14799 and will need to be rebased when that merges. In the meantime you can look at the HEAD commit on the PR branch to see the contents of just this PR: 00d71df#14799 has merged and this has been rebased now.