Fixed a bug where nonequal boxes were considered equal (backport #14716) #14722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed a bug where nonequal boxes were considered equal * Release note * Update releasenotes/notes/fix-box-eq-check-1ff339fcc1db983f.yaml * Update releasenotes/notes/fix-box-eq-check-1ff339fcc1db983f.yaml --------- Co-authored-by: Matthew Treinish <mtreinish@kortar.org> (cherry picked from commit 925f144)
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
mtreinish
approved these changes
Jul 10, 2025
Pull Request Test Coverage Report for Build 16201623491Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
_box_eqto return non equality when the boxes have differentunitfields.Details and comments
It seems
_box_eqis invoked only when comparing circuits, notDAGOpNodes. There might be other cases we miss in other nodes due to the stricter check used byDAGOpNode.This is an automatic backport of pull request #14716 done by [Mergify](https://mergify.com).