Fixed a bug where nonequal boxes were considered equal #14716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One or more of the following people are relevant to this code:
|
|
The fix looks good, but can you add a release note so this can be backported to 2.1.1? |
Pull Request Test Coverage Report for Build 16200586974Details
💛 - Coveralls |
mtreinish
reviewed
Jul 10, 2025
mtreinish
previously approved these changes
Jul 10, 2025
mtreinish
reviewed
Jul 10, 2025
mtreinish
approved these changes
Jul 10, 2025
mergify bot
pushed a commit
that referenced
this pull request
Jul 10, 2025
* Fixed a bug where nonequal boxes were considered equal * Release note * Update releasenotes/notes/fix-box-eq-check-1ff339fcc1db983f.yaml * Update releasenotes/notes/fix-box-eq-check-1ff339fcc1db983f.yaml --------- Co-authored-by: Matthew Treinish <mtreinish@kortar.org> (cherry picked from commit 925f144)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 10, 2025
* Fixed a bug where nonequal boxes were considered equal * Release note * Update releasenotes/notes/fix-box-eq-check-1ff339fcc1db983f.yaml * Update releasenotes/notes/fix-box-eq-check-1ff339fcc1db983f.yaml --------- (cherry picked from commit 925f144) Co-authored-by: gadial <gadial@gmail.com> Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
_box_eqto return non equality when the boxes have differentunitfields.Details and comments
It seems
_box_eqis invoked only when comparing circuits, notDAGOpNodes. There might be other cases we miss in other nodes due to the stricter check used byDAGOpNode.