-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Fix ApplyLayout
with empty layout (backport #14606)
#14615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It's unlikely to ever be useful, but strictly there still is a well-defined behaviour for `ApplyLayout` on a zero-qubit circuit and backend. Previously, the pass errored out falsely asserting user error. (cherry picked from commit d0630fd)
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
Looks like this is failing due to an actual issue:
|
Kevin: it's probably because the test is written under the assumption that #13820 was available. The tests probably need rewriting to instead construct a |
Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
Pull Request Test Coverage Report for Build 16980897218Details
💛 - Coveralls |
Summary
It's unlikely to ever be useful, but strictly there still is a well-defined behaviour for
ApplyLayout
on a zero-qubit circuit and backend. Previously, the pass errored out falsely asserting user error.Details and comments
This is an automatic backport of pull request #14606 done by [Mergify](https://mergify.com).