Restore correct max_trials behaviour for VF2Layout pass (backport #14667) #14692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Restore correct max_trials behaviour for VF2Layout pass The VF2Layout pass is documented as setting a trial limit equivalent to the being based on the number of edges of the interaction or connectivity graph. Additionally it supports being a negative value to run unbounded. However, when vf2 layout was ported to rust in #14056 this behavior was not preserved. It was not able to handle negative values and also a value of None was treated as unbounded. This commit corrects these oversights so the argument to the pass is handled correctly as documented. * Improve tests The previous version of the tests in this module didn't set the seed correctly, so the rust component was not run. Similarly, the tests didn't cover the strict direction path. This commit corrects both oversights so the tests added in this PR cover the fix. (cherry picked from commit 6e4d83c)
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 16111438866Details
💛 - Coveralls |
1ucian0
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The VF2Layout pass is documented as setting a trial limit equivalent to the being based on the number of edges of the interaction or connectivity graph. Additionally it supports being a negative value to run unbounded. However, when vf2 layout was ported to rust in #14056 this behavior was not preserved. It was not able to handle negative values and also a value of None was treated as unbounded. This commit corrects these oversights so the argument to the pass is handled correctly as documented.
Details and comments
This is an automatic backport of pull request #14667 done by Mergify.