Skip to content

Fix MCXSynthesis1DirtyKG24 and MCXSynthesis2DirtyKG24 plugins (backport #14670) #14671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 26, 2025

Summary

In #14143 we have introduced new MCXGate synthesis plugins MCXSynthesis2CleanKG24, MCXSynthesis2DirtyKG24, MCXSynthesis1CleanKG24, MCXSynthesis1DirtyKG24. In particular, the plugin MCXSynthesis1DirtyKG24 should apply when there is (at least) one available dirty auxiliary qubit, and the plugin MCXSynthesis2DirtyKG24 should apply when there are (at least) two available dirty auxiliary qubits. However, the number of dirty qubits available failed to include the number of clean qubits available, and in particular MCXSynthesis2DirtyKG24 failed to apply with one clean and one dirty auxiliary qubits.


This is an automatic backport of pull request #14670 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner June 26, 2025 12:19
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@github-actions github-actions bot added this to the 2.1.1 milestone Jun 26, 2025
@github-actions github-actions bot added the Changelog: Bugfix Include in the "Fixed" section of the changelog label Jun 26, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 15901652485

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 88.002%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 5 92.48%
Totals Coverage Status
Change from base Build 15866302953: 0.02%
Covered Lines: 83067
Relevant Lines: 94392

💛 - Coveralls

@mtreinish mtreinish added this pull request to the merge queue Jun 27, 2025
Merged via the queue into stable/2.1 with commit a2a2677 Jun 27, 2025
29 checks passed
@mtreinish mtreinish deleted the mergify/bp/stable/2.1/pr-14670 branch June 27, 2025 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants