Skip to content

Fix MCXSynthesis1DirtyKG24 and MCXSynthesis2DirtyKG24 plugins #14670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025

Conversation

alexanderivrii
Copy link
Member

Summary

In #14143 we have introduced new MCXGate synthesis plugins MCXSynthesis2CleanKG24, MCXSynthesis2DirtyKG24, MCXSynthesis1CleanKG24, MCXSynthesis1DirtyKG24. In particular, the plugin MCXSynthesis1DirtyKG24 should apply when there is (at least) one available dirty auxiliary qubit, and the plugin MCXSynthesis2DirtyKG24 should apply when there are (at least) two available dirty auxiliary qubits. However, the number of dirty qubits available failed to include the number of clean qubits available, and in particular MCXSynthesis2DirtyKG24 failed to apply with one clean and one dirty auxiliary qubits.

@alexanderivrii alexanderivrii requested a review from a team as a code owner June 26, 2025 07:40
@alexanderivrii alexanderivrii added the Changelog: Bugfix Include in the "Fixed" section of the changelog label Jun 26, 2025
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@mtreinish mtreinish added the stable backport potential The bug might be minimal and/or import enough to be port to stable label Jun 26, 2025
@mtreinish mtreinish added this to the 2.1.1 milestone Jun 26, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 15895927818

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.009%) to 88.038%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 4 92.73%
crates/qasm2/src/parse.rs 6 97.61%
Totals Coverage Status
Change from base Build 15864956681: 0.009%
Covered Lines: 84054
Relevant Lines: 95475

💛 - Coveralls

Copy link
Member

@ShellyGarion ShellyGarion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this!

@ShellyGarion ShellyGarion added this pull request to the merge queue Jun 26, 2025
Merged via the queue into Qiskit:main with commit 8353251 Jun 26, 2025
28 checks passed
mergify bot pushed a commit that referenced this pull request Jun 26, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jun 27, 2025
) (#14671)

(cherry picked from commit 8353251)

Co-authored-by: Alexander Ivrii <alexi@il.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants