Add missing stacklevel to deprecation warning for 3.9 #14651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Qiskit 2.1.0 we deprecated Python 3.9 support since it will not be supported in the 2.3.0 release. However, the warnings.warn call to emit the deprecation warning was missing the stacklevel argument. This means that the default Python warning filters will not display the warning to end users because it's not user code that's triggering the warn() call. This commit fixes this oversight so that Python 3.9 users will see the warning by default.
|
One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 15790710847Details
💛 - Coveralls |
mergify bot
pushed a commit
that referenced
this pull request
Jun 23, 2025
In Qiskit 2.1.0 we deprecated Python 3.9 support since it will not be supported in the 2.3.0 release. However, the warnings.warn call to emit the deprecation warning was missing the stacklevel argument. This means that the default Python warning filters will not display the warning to end users because it's not user code that's triggering the warn() call. This commit fixes this oversight so that Python 3.9 users will see the warning by default. (cherry picked from commit 2b0a682)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 1, 2025
In Qiskit 2.1.0 we deprecated Python 3.9 support since it will not be supported in the 2.3.0 release. However, the warnings.warn call to emit the deprecation warning was missing the stacklevel argument. This means that the default Python warning filters will not display the warning to end users because it's not user code that's triggering the warn() call. This commit fixes this oversight so that Python 3.9 users will see the warning by default. (cherry picked from commit 2b0a682) Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In Qiskit 2.1.0 we deprecated Python 3.9 support since it will not be supported in the 2.3.0 release. However, the warnings.warn call to emit the deprecation warning was missing the stacklevel argument. This means that the default Python warning filters will not display the warning to end users because it's not user code that's triggering the warn() call. This commit fixes this oversight so that Python 3.9 users will see the warning by default.
Details and comments