Add sanity check for all crates to CI #14527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One or more of the following people are relevant to this code:
|
0f5d233 to
53e3e61
Compare
This commit adds a new step to the rust unit test CI job that runs cargo check on each of our crates in isolation to ensure that they all build on their own. This will prevent issues like what was fixed in Qiskit#14526 from popping up again (which has happened before).
|
The CI failure is expected as it's catching what #14526 is fixing: https://github.com/Qiskit/qiskit/actions/runs/15427994770/job/43419580721?pr=14527#step:4:557 which confirms this is working as expected. I'll rebase after #14526 merges so this is unblocked. |
Pull Request Test Coverage Report for Build 15428700225Details
💛 - Coveralls |
jakelishman
approved these changes
Jun 4, 2025
rahaman-quantum
pushed a commit
to rahaman-quantum/qiskit
that referenced
this pull request
Jun 20, 2025
This commit adds a new step to the rust unit test CI job that runs cargo check on each of our crates in isolation to ensure that they all build on their own. This will prevent issues like what was fixed in Qiskit#14526 from popping up again (which has happened before).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit adds a new step to the rust unit test CI job that runs cargo check on each of our crates in isolation to ensure that they all build on their own. This will prevent issues like what was fixed in #14526 from popping up again (which has happened before).
Details and comments