Use correct minimum rustworkx requirement version #14507
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rustworkx version we have previously had set as the minimum requirement is not correct. It was listed as 0.15.0 but we are using `PyDiGraph.neighbors_undirected()` since Qiskit#14218 merged which was added in rustworkx 0.16.0. [1] This means the requirement is incorrect and if you try to run Qiskit with rustworkx 0.15.0 it will not work when this method is run. This commit corrects this issue and bumps the minimum supported rustworkx version in the requirements list to 0.16.0. [1] https://www.rustworkx.org/release_notes.html#relnotes-0-16-0
|
One or more of the following people are relevant to this code:
|
|
What is problematic here is that #14218 was backported to stable/2.0 and stable/1.4. So we should at least do the same, although we typically try to avoid raising minimum dependency versions in patch releases. We might want to instead look at rewriting the vf2 utils function to avoid using |
jakelishman
reviewed
May 29, 2025
There was a problem hiding this comment.
If this is the only problem with Rustworkx 0.15, let's leave our requirement and that and put the workaround on all branches.
My new VF2 obsoletes that Python-space code anyway, and that should come in for the 2.2 cycle, so probably nicer not to bump the dependency for this alone. I didn't realise that that was a 0.16 method when I wrote it.
|
That was the only place I hit, but I didn't test beyond it. I can run the test suite with 0.15.0 installed to verify there is nothing else and do that instead. We do require rustworkx-core 0.16.0 but that's obviously different. |
Pull Request Test Coverage Report for Build 15333752715Details
💛 - Coveralls |
mtreinish
added a commit
to mtreinish/qiskit-core
that referenced
this pull request
May 30, 2025
In Qiskit#14218 the vf2_utils module was updated to use the `PyDiGraph.neighbors_undirected()` method which was added in 0.16.0. However that PR neglected to bump the minimum required version of rustworkx to 0.16.0 from 0.15.0 which is the current minim version listed. While we could bump the minimum version (see Qiskit#14507) to rustworkx 0.16.0 using this method isn't strictly necessary and Qiskit#14218 was backported to stable branches and backporting a version bump is not desireable. This commit instead just updates the rustworkx usage to use APIs in 0.15.0. This PR will need to be backported to stable/1.4 and stable/2.0 to fix compatibility with the listed rustworkx requirement. However, in the backport a fix note will be needed to document that the release fixes compatibility with the listed requirement.
mtreinish
added a commit
to mtreinish/qiskit-core
that referenced
this pull request
May 30, 2025
In Qiskit#14218 the vf2_utils module was updated to use the `PyDiGraph.neighbors_undirected()` method which was added in 0.16.0. However that PR neglected to bump the minimum required version of rustworkx to 0.16.0 from 0.15.0 which is the current minim version listed. While we could bump the minimum version (see Qiskit#14507) to rustworkx 0.16.0 using this method isn't strictly necessary and Qiskit#14218 was backported to stable branches and backporting a version bump is not desireable. This commit instead just updates the rustworkx usage to use APIs in 0.15.0. This PR will need to be backported to stable/1.4 and stable/2.0 to fix compatibility with the listed rustworkx requirement. However, in the backport a fix note will be needed to document that the release fixes compatibility with the listed requirement.
|
Closing this in favor of: #14513 |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 4, 2025
* Avoid using rustworkx 0.16.0 methods in vf2_utils In #14218 the vf2_utils module was updated to use the `PyDiGraph.neighbors_undirected()` method which was added in 0.16.0. However that PR neglected to bump the minimum required version of rustworkx to 0.16.0 from 0.15.0 which is the current minim version listed. While we could bump the minimum version (see #14507) to rustworkx 0.16.0 using this method isn't strictly necessary and #14218 was backported to stable branches and backporting a version bump is not desireable. This commit instead just updates the rustworkx usage to use APIs in 0.15.0. This PR will need to be backported to stable/1.4 and stable/2.0 to fix compatibility with the listed rustworkx requirement. However, in the backport a fix note will be needed to document that the release fixes compatibility with the listed requirement. * Correctly handle duplicates across successors and predecessors
mergify bot
pushed a commit
that referenced
this pull request
Jun 4, 2025
* Avoid using rustworkx 0.16.0 methods in vf2_utils In #14218 the vf2_utils module was updated to use the `PyDiGraph.neighbors_undirected()` method which was added in 0.16.0. However that PR neglected to bump the minimum required version of rustworkx to 0.16.0 from 0.15.0 which is the current minim version listed. While we could bump the minimum version (see #14507) to rustworkx 0.16.0 using this method isn't strictly necessary and #14218 was backported to stable branches and backporting a version bump is not desireable. This commit instead just updates the rustworkx usage to use APIs in 0.15.0. This PR will need to be backported to stable/1.4 and stable/2.0 to fix compatibility with the listed rustworkx requirement. However, in the backport a fix note will be needed to document that the release fixes compatibility with the listed requirement. * Correctly handle duplicates across successors and predecessors (cherry picked from commit 9aa1a29)
mergify bot
pushed a commit
that referenced
this pull request
Jun 4, 2025
* Avoid using rustworkx 0.16.0 methods in vf2_utils In #14218 the vf2_utils module was updated to use the `PyDiGraph.neighbors_undirected()` method which was added in 0.16.0. However that PR neglected to bump the minimum required version of rustworkx to 0.16.0 from 0.15.0 which is the current minim version listed. While we could bump the minimum version (see #14507) to rustworkx 0.16.0 using this method isn't strictly necessary and #14218 was backported to stable branches and backporting a version bump is not desireable. This commit instead just updates the rustworkx usage to use APIs in 0.15.0. This PR will need to be backported to stable/1.4 and stable/2.0 to fix compatibility with the listed rustworkx requirement. However, in the backport a fix note will be needed to document that the release fixes compatibility with the listed requirement. * Correctly handle duplicates across successors and predecessors (cherry picked from commit 9aa1a29)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 12, 2025
…14533) * Avoid using rustworkx 0.16.0 methods in vf2_utils (#14513) * Avoid using rustworkx 0.16.0 methods in vf2_utils In #14218 the vf2_utils module was updated to use the `PyDiGraph.neighbors_undirected()` method which was added in 0.16.0. However that PR neglected to bump the minimum required version of rustworkx to 0.16.0 from 0.15.0 which is the current minim version listed. While we could bump the minimum version (see #14507) to rustworkx 0.16.0 using this method isn't strictly necessary and #14218 was backported to stable branches and backporting a version bump is not desireable. This commit instead just updates the rustworkx usage to use APIs in 0.15.0. This PR will need to be backported to stable/1.4 and stable/2.0 to fix compatibility with the listed rustworkx requirement. However, in the backport a fix note will be needed to document that the release fixes compatibility with the listed requirement. * Correctly handle duplicates across successors and predecessors (cherry picked from commit 9aa1a29) * Add release note --------- Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 12, 2025
…14534) * Avoid using rustworkx 0.16.0 methods in vf2_utils (#14513) * Avoid using rustworkx 0.16.0 methods in vf2_utils In #14218 the vf2_utils module was updated to use the `PyDiGraph.neighbors_undirected()` method which was added in 0.16.0. However that PR neglected to bump the minimum required version of rustworkx to 0.16.0 from 0.15.0 which is the current minim version listed. While we could bump the minimum version (see #14507) to rustworkx 0.16.0 using this method isn't strictly necessary and #14218 was backported to stable branches and backporting a version bump is not desireable. This commit instead just updates the rustworkx usage to use APIs in 0.15.0. This PR will need to be backported to stable/1.4 and stable/2.0 to fix compatibility with the listed rustworkx requirement. However, in the backport a fix note will be needed to document that the release fixes compatibility with the listed requirement. * Correctly handle duplicates across successors and predecessors (cherry picked from commit 9aa1a29) * Add release note --------- Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
rahaman-quantum
pushed a commit
to rahaman-quantum/qiskit
that referenced
this pull request
Jun 20, 2025
* Avoid using rustworkx 0.16.0 methods in vf2_utils In Qiskit#14218 the vf2_utils module was updated to use the `PyDiGraph.neighbors_undirected()` method which was added in 0.16.0. However that PR neglected to bump the minimum required version of rustworkx to 0.16.0 from 0.15.0 which is the current minim version listed. While we could bump the minimum version (see Qiskit#14507) to rustworkx 0.16.0 using this method isn't strictly necessary and Qiskit#14218 was backported to stable branches and backporting a version bump is not desireable. This commit instead just updates the rustworkx usage to use APIs in 0.15.0. This PR will need to be backported to stable/1.4 and stable/2.0 to fix compatibility with the listed rustworkx requirement. However, in the backport a fix note will be needed to document that the release fixes compatibility with the listed requirement. * Correctly handle duplicates across successors and predecessors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The rustworkx version we have previously had set as the minimum requirement is not correct. It was listed as 0.15.0 but we are using
PyDiGraph.neighbors_undirected()since #14218 merged which was added in rustworkx 0.16.0. [1] This means the requirement is incorrect and if you try to run Qiskit with rustworkx 0.15.0 it will not work when this method is run. This commit corrects this issue and bumps the minimum supported rustworkx version in the requirements list to 0.16.0.Details and comments
[1] https://www.rustworkx.org/release_notes.html#relnotes-0-16-0