Fix random number generator seed argument for quantum_volume #14586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One or more of the following people are relevant to this code:
|
The `seed` argument to `quantum_volume` being a `numpy.random.Generator` resulted in `integers` being called with 0 for the `low` argument. When called with only a `low` argument like this, this value is taken as one more than the maximum and 0 is treated as the minimum. This resulted in a `TypeError` because the range is from 0 to -1. Here the handling of `Generator` was updated to match how the deprecated `QuantumVolume` class handled `seed` (which was slightly odd -- it caps the range at the int64 limit even though the argument is a `u64` in the Rust function -- but probably fine; keeping the range helps keep the behavior consistent between `QuantumVolume` and `quantum_volume` for a generator with the same seed).
Pull Request Test Coverage Report for Build 15617205136Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
@Mergifyio backport stable/1.4 stable/2.0 stable/2.1 |
✅ Backports have been created
|
mtreinish
approved these changes
Jun 12, 2025
mergify bot
pushed a commit
that referenced
this pull request
Jun 12, 2025
* Fix random number generator seed argument for quantum_volume The `seed` argument to `quantum_volume` being a `numpy.random.Generator` resulted in `integers` being called with 0 for the `low` argument. When called with only a `low` argument like this, this value is taken as one more than the maximum and 0 is treated as the minimum. This resulted in a `TypeError` because the range is from 0 to -1. Here the handling of `Generator` was updated to match how the deprecated `QuantumVolume` class handled `seed` (which was slightly odd -- it caps the range at the int64 limit even though the argument is a `u64` in the Rust function -- but probably fine; keeping the range helps keep the behavior consistent between `QuantumVolume` and `quantum_volume` for a generator with the same seed). * Address pylint's misunderstanding of the test import (cherry picked from commit ba74b5c)
mergify bot
pushed a commit
that referenced
this pull request
Jun 12, 2025
* Fix random number generator seed argument for quantum_volume The `seed` argument to `quantum_volume` being a `numpy.random.Generator` resulted in `integers` being called with 0 for the `low` argument. When called with only a `low` argument like this, this value is taken as one more than the maximum and 0 is treated as the minimum. This resulted in a `TypeError` because the range is from 0 to -1. Here the handling of `Generator` was updated to match how the deprecated `QuantumVolume` class handled `seed` (which was slightly odd -- it caps the range at the int64 limit even though the argument is a `u64` in the Rust function -- but probably fine; keeping the range helps keep the behavior consistent between `QuantumVolume` and `quantum_volume` for a generator with the same seed). * Address pylint's misunderstanding of the test import (cherry picked from commit ba74b5c)
This was referenced Jun 12, 2025
mergify bot
pushed a commit
that referenced
this pull request
Jun 12, 2025
* Fix random number generator seed argument for quantum_volume The `seed` argument to `quantum_volume` being a `numpy.random.Generator` resulted in `integers` being called with 0 for the `low` argument. When called with only a `low` argument like this, this value is taken as one more than the maximum and 0 is treated as the minimum. This resulted in a `TypeError` because the range is from 0 to -1. Here the handling of `Generator` was updated to match how the deprecated `QuantumVolume` class handled `seed` (which was slightly odd -- it caps the range at the int64 limit even though the argument is a `u64` in the Rust function -- but probably fine; keeping the range helps keep the behavior consistent between `QuantumVolume` and `quantum_volume` for a generator with the same seed). * Address pylint's misunderstanding of the test import (cherry picked from commit ba74b5c)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 13, 2025
…#14592) * Fix random number generator seed argument for quantum_volume The `seed` argument to `quantum_volume` being a `numpy.random.Generator` resulted in `integers` being called with 0 for the `low` argument. When called with only a `low` argument like this, this value is taken as one more than the maximum and 0 is treated as the minimum. This resulted in a `TypeError` because the range is from 0 to -1. Here the handling of `Generator` was updated to match how the deprecated `QuantumVolume` class handled `seed` (which was slightly odd -- it caps the range at the int64 limit even though the argument is a `u64` in the Rust function -- but probably fine; keeping the range helps keep the behavior consistent between `QuantumVolume` and `quantum_volume` for a generator with the same seed). * Address pylint's misunderstanding of the test import (cherry picked from commit ba74b5c) Co-authored-by: Will Shanks <willshanks@us.ibm.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 13, 2025
…#14591) * Fix random number generator seed argument for quantum_volume The `seed` argument to `quantum_volume` being a `numpy.random.Generator` resulted in `integers` being called with 0 for the `low` argument. When called with only a `low` argument like this, this value is taken as one more than the maximum and 0 is treated as the minimum. This resulted in a `TypeError` because the range is from 0 to -1. Here the handling of `Generator` was updated to match how the deprecated `QuantumVolume` class handled `seed` (which was slightly odd -- it caps the range at the int64 limit even though the argument is a `u64` in the Rust function -- but probably fine; keeping the range helps keep the behavior consistent between `QuantumVolume` and `quantum_volume` for a generator with the same seed). * Address pylint's misunderstanding of the test import (cherry picked from commit ba74b5c) Co-authored-by: Will Shanks <willshanks@us.ibm.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 13, 2025
…#14590) * Fix random number generator seed argument for quantum_volume The `seed` argument to `quantum_volume` being a `numpy.random.Generator` resulted in `integers` being called with 0 for the `low` argument. When called with only a `low` argument like this, this value is taken as one more than the maximum and 0 is treated as the minimum. This resulted in a `TypeError` because the range is from 0 to -1. Here the handling of `Generator` was updated to match how the deprecated `QuantumVolume` class handled `seed` (which was slightly odd -- it caps the range at the int64 limit even though the argument is a `u64` in the Rust function -- but probably fine; keeping the range helps keep the behavior consistent between `QuantumVolume` and `quantum_volume` for a generator with the same seed). * Address pylint's misunderstanding of the test import (cherry picked from commit ba74b5c) Co-authored-by: Will Shanks <willshanks@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
seedargument toquantum_volumebeing anumpy.random.Generatorresulted inintegersbeing called with 0 for thelowargument. When called with only alowargument like this, this value is taken as one more than the maximum and 0 is treated as the minimum. This resulted in aTypeErrorbecause the range is from 0 to -1. Here the handling ofGeneratorwas updated to match how the deprecatedQuantumVolumeclass handledseed(which was slightly odd -- it caps the range at the int64 limit even though the argument is au64in the Rust function -- but probably fine; keeping the range helps keep the behavior consistent betweenQuantumVolumeandquantum_volumefor a generator with the same seed).