Skip to content

allows string values in assign_parameters with strict=False (backport #14365) #14553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 6, 2025

Summary

Allows for string values as arguments in assign_parameters with strict=False.
Fixes #13933

Details and comments


This is an automatic backport of pull request #14365 done by [Mergify](https://mergify.com).

* allows string values in assign_parameters with strict=False

* added release notes and a test case

* formatting changes in unittest file

* Changes with `strict` passed to an inner method.

* formatting changes in release notes

* corrections in inner method

* Make test more rigorous

---------

Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
(cherry picked from commit 25dec6a)
@mergify mergify bot requested a review from a team as a code owner June 6, 2025 15:01
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@github-actions github-actions bot added Changelog: Bugfix Include in the "Fixed" section of the changelog mod: circuit Related to the core of the `QuantumCircuit` class or the circuit library labels Jun 6, 2025
@jakelishman jakelishman added this to the 1.4.4 milestone Jun 6, 2025
@jakelishman jakelishman enabled auto-merge June 6, 2025 15:04
@coveralls
Copy link

Pull Request Test Coverage Report for Build 15493589572

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • 25 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.02%) to 88.787%

Files with Coverage Reduction New Missed Lines %
crates/accelerate/src/two_qubit_decompose.rs 1 91.96%
crates/accelerate/src/unitary_synthesis.rs 1 93.21%
crates/qasm2/src/lex.rs 5 92.23%
crates/qasm2/src/parse.rs 18 96.23%
Totals Coverage Status
Change from base Build 15443794922: -0.02%
Covered Lines: 79471
Relevant Lines: 89507

💛 - Coveralls

@jakelishman jakelishman added this pull request to the merge queue Jun 6, 2025
Merged via the queue into stable/1.4 with commit f6bae2c Jun 6, 2025
20 checks passed
@jakelishman jakelishman deleted the mergify/bp/stable/1.4/pr-14365 branch June 9, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog mod: circuit Related to the core of the `QuantumCircuit` class or the circuit library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants