Skip to content

Fix behavior of HLS plugins after preserve_order=False (backport #14539) #14547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 12, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 6, 2025

Summary

The HLS plugins for PauliEvolutionGates were modifying the original circuit's gate.synthesis.preserve_order attribute, which would result in an unexpected behavior of the pass manager when run multiple times. The bug can be fixed by restoring the property in the plugin after it being used in .synthesize.

Details and comments


This is an automatic backport of pull request #14539 done by [Mergify](https://mergify.com).

(cherry picked from commit 2982004)

# Conflicts:
#	qiskit/transpiler/passes/synthesis/hls_plugins.py
@mergify mergify bot requested a review from alexanderivrii as a code owner June 6, 2025 09:38
Copy link
Contributor Author

mergify bot commented Jun 6, 2025

Cherry-pick of 2982004 has failed:

On branch mergify/bp/stable/1.4/pr-14539
Your branch is up to date with 'origin/stable/1.4'.

You are currently cherry-picking commit 29820048d.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   releasenotes/notes/fix-preserve-order-0b8c1bf383f42297.yaml
	modified:   test/python/transpiler/test_high_level_synthesis.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   qiskit/transpiler/passes/synthesis/hls_plugins.py

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot requested a review from ShellyGarion as a code owner June 6, 2025 09:38
@mergify mergify bot added the conflicts used by mergify when there are conflicts in a port label Jun 6, 2025
@mergify mergify bot requested a review from a team as a code owner June 6, 2025 09:38
@mergify mergify bot added the conflicts used by mergify when there are conflicts in a port label Jun 6, 2025
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@github-actions github-actions bot added the Changelog: Bugfix Include in the "Fixed" section of the changelog label Jun 6, 2025
@github-actions github-actions bot added this to the 2.0.3 milestone Jun 6, 2025
ElePT
ElePT previously approved these changes Jun 6, 2025
@ElePT ElePT enabled auto-merge June 6, 2025 09:40
@ElePT ElePT disabled auto-merge June 6, 2025 09:42
@ElePT ElePT enabled auto-merge June 6, 2025 09:43
@coveralls
Copy link

Pull Request Test Coverage Report for Build 15487640023

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • 31 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.02%) to 88.787%

Files with Coverage Reduction New Missed Lines %
crates/accelerate/src/unitary_synthesis.rs 1 93.21%
crates/qasm2/src/lex.rs 6 91.98%
crates/qasm2/src/parse.rs 24 96.23%
Totals Coverage Status
Change from base Build 15443794922: -0.02%
Covered Lines: 79473
Relevant Lines: 89510

💛 - Coveralls

@ElePT ElePT added this pull request to the merge queue Jun 12, 2025
Merged via the queue into stable/1.4 with commit c100656 Jun 12, 2025
19 checks passed
@ElePT ElePT deleted the mergify/bp/stable/1.4/pr-14539 branch June 12, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog conflicts used by mergify when there are conflicts in a port
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants