Fixed AND terms for OR in quantum_or.py
#14436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed AND terms for OR
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
|
|
|
|
Closed
|
Thanks for doing this! You need to sign CLA (Contributor License Agreement). Also, could you add a short release note (calling an OrGate as "and" could have possibly led to various problems). |
Cryoris
reviewed
May 23, 2025
releasenotes/notes/fix-calling-OR-gate-as-AND-f1b364d04734098d.yaml
Outdated
Show resolved
Hide resolved
….yaml Co-authored-by: Julien Gacon <gaconju@gmail.com>
Cryoris
approved these changes
May 23, 2025
Pull Request Test Coverage Report for Build 15234826798Details
💛 - Coveralls |
mergify bot
pushed a commit
that referenced
this pull request
May 25, 2025
* Update quantum_or.py Fixed AND terms for OR * Create fix-calling-OR-gate-as-AND-f1b364d04734098d.yaml * Update releasenotes/notes/fix-calling-OR-gate-as-AND-f1b364d04734098d.yaml Co-authored-by: Julien Gacon <gaconju@gmail.com> --------- Co-authored-by: Julien Gacon <gaconju@gmail.com> Co-authored-by: Alexander Ivrii <alexi@il.ibm.com> (cherry picked from commit c61d797)
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 25, 2025
* Update quantum_or.py Fixed AND terms for OR * Create fix-calling-OR-gate-as-AND-f1b364d04734098d.yaml * Update releasenotes/notes/fix-calling-OR-gate-as-AND-f1b364d04734098d.yaml --------- (cherry picked from commit c61d797) Co-authored-by: Rocky <rockygitt@gmail.com> Co-authored-by: Julien Gacon <gaconju@gmail.com> Co-authored-by: Alexander Ivrii <alexi@il.ibm.com>
|
@Mergifyio backport stable/1.4 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
May 27, 2025
* Update quantum_or.py Fixed AND terms for OR * Create fix-calling-OR-gate-as-AND-f1b364d04734098d.yaml * Update releasenotes/notes/fix-calling-OR-gate-as-AND-f1b364d04734098d.yaml Co-authored-by: Julien Gacon <gaconju@gmail.com> --------- Co-authored-by: Julien Gacon <gaconju@gmail.com> Co-authored-by: Alexander Ivrii <alexi@il.ibm.com> (cherry picked from commit c61d797)
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 28, 2025
* Fixed AND terms for OR in `quantum_or.py` (#14436) * Update quantum_or.py Fixed AND terms for OR * Create fix-calling-OR-gate-as-AND-f1b364d04734098d.yaml * Update releasenotes/notes/fix-calling-OR-gate-as-AND-f1b364d04734098d.yaml Co-authored-by: Julien Gacon <gaconju@gmail.com> --------- Co-authored-by: Julien Gacon <gaconju@gmail.com> Co-authored-by: Alexander Ivrii <alexi@il.ibm.com> (cherry picked from commit c61d797) * Update release note --------- Co-authored-by: Rocky <rockygitt@gmail.com> Co-authored-by: Julien Gacon <gaconju@gmail.com> Co-authored-by: Alexander Ivrii <alexi@il.ibm.com> Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
rahaman-quantum
pushed a commit
to rahaman-quantum/qiskit
that referenced
this pull request
Jun 20, 2025
* Update quantum_or.py Fixed AND terms for OR * Create fix-calling-OR-gate-as-AND-f1b364d04734098d.yaml * Update releasenotes/notes/fix-calling-OR-gate-as-AND-f1b364d04734098d.yaml Co-authored-by: Julien Gacon <gaconju@gmail.com> --------- Co-authored-by: Julien Gacon <gaconju@gmail.com> Co-authored-by: Alexander Ivrii <alexi@il.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed AND terms for OR.
Issue: Qiskit/qiskit#14434