Revert "Add qk_circuit_unitary (#14334)"
#14492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This broke the C API tests but somehow made it through CI. We need teh CI fix, and to send the PR back to review. This reverts commit 25a34b0.
|
One or more of the following people are relevant to this code:
|
This was referenced May 28, 2025
kevinhartman
approved these changes
May 28, 2025
mtreinish
added a commit
to mtreinish/qiskit-core
that referenced
this pull request
May 28, 2025
We originally merged this C API function in Qiskit#14334 but it had to be reverted in Qiskit#14492 because the C API tests conflicted with Qiskit#14340 and failed the tests. It was only able to merge because of a brief configuration issue with CI. This commit reapplies the originally PR and fixes the test conflict. This reverts commit 49874c6.
mtreinish
added a commit
to mtreinish/qiskit-core
that referenced
this pull request
May 30, 2025
We originally merged this C API function in Qiskit#14334 but it had to be reverted in Qiskit#14492 because the C API tests conflicted with Qiskit#14340 and failed the tests. It was only able to merge because of a brief configuration issue with CI. This commit reapplies the originally PR and fixes the test conflict. This reverts commit 49874c6.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 2, 2025
* Reapply "Add ``qk_circuit_unitary`` (#14334)" (#14492) We originally merged this C API function in #14334 but it had to be reverted in #14492 because the C API tests conflicted with #14340 and failed the tests. It was only able to merge because of a brief configuration issue with CI. This commit reapplies the originally PR and fixes the test conflict. This reverts commit 49874c6. * Add tests for different sized matrices
rahaman-quantum
pushed a commit
to rahaman-quantum/qiskit
that referenced
this pull request
Jun 20, 2025
This broke the C API tests but somehow made it through CI. We need teh CI fix, and to send the PR back to review. This reverts commit 25a34b0.
rahaman-quantum
pushed a commit
to rahaman-quantum/qiskit
that referenced
this pull request
Jun 20, 2025
…iskit#14509) * Reapply "Add ``qk_circuit_unitary`` (Qiskit#14334)" (Qiskit#14492) We originally merged this C API function in Qiskit#14334 but it had to be reverted in Qiskit#14492 because the C API tests conflicted with Qiskit#14340 and failed the tests. It was only able to merge because of a brief configuration issue with CI. This commit reapplies the originally PR and fixes the test conflict. This reverts commit 49874c6. * Add tests for different sized matrices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This broke the C API tests but somehow made it through CI. We need teh CI fix, and to send the PR back to review.
This reverts commit 25a34b0.
Summary
Details and comments