Fix Sabre rebuild with nested Var and Stretch
#14488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `empty_dag` helper, used to construct control-flow blocks, in the rebuilder failed to account for `Var` or `Stretch` nodes. We have integration tests in `test/python/compiler/test_transpiler.py` that _in theory_ should have caught this, but in practice failed to because they are accidentally using all-to-all connectivity backends, so Sabre never runs in them.
|
One or more of the following people are relevant to this code:
|
|
@mergify backport stable/1.4 |
✅ Backports have been created
|
|
This won't actually apply cleanly to 1.4 because of the stretches, but the vars part of it does need backporting. |
Pull Request Test Coverage Report for Build 15304049344Details
💛 - Coveralls |
kevinhartman
approved these changes
May 28, 2025
mergify bot
pushed a commit
that referenced
this pull request
May 28, 2025
The `empty_dag` helper, used to construct control-flow blocks, in the rebuilder failed to account for `Var` or `Stretch` nodes. We have integration tests in `test/python/compiler/test_transpiler.py` that _in theory_ should have caught this, but in practice failed to because they are accidentally using all-to-all connectivity backends, so Sabre never runs in them. (cherry picked from commit 985bd7a) # Conflicts: # test/python/transpiler/test_sabre_swap.py
mergify bot
pushed a commit
that referenced
this pull request
May 28, 2025
The `empty_dag` helper, used to construct control-flow blocks, in the rebuilder failed to account for `Var` or `Stretch` nodes. We have integration tests in `test/python/compiler/test_transpiler.py` that _in theory_ should have caught this, but in practice failed to because they are accidentally using all-to-all connectivity backends, so Sabre never runs in them. (cherry picked from commit 985bd7a)
This was referenced May 28, 2025
jakelishman
added a commit
that referenced
this pull request
May 28, 2025
The `empty_dag` helper, used to construct control-flow blocks, in the rebuilder failed to account for `Var` or `Stretch` nodes. We have integration tests in `test/python/compiler/test_transpiler.py` that _in theory_ should have caught this, but in practice failed to because they are accidentally using all-to-all connectivity backends, so Sabre never runs in them.
jakelishman
added a commit
that referenced
this pull request
May 28, 2025
The `empty_dag` helper, used to construct control-flow blocks, in the rebuilder failed to account for `Var` or `Stretch` nodes. We have integration tests in `test/python/compiler/test_transpiler.py` that _in theory_ should have caught this, but in practice failed to because they are accidentally using all-to-all connectivity backends, so Sabre never runs in them.
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 28, 2025
The `empty_dag` helper, used to construct control-flow blocks, in the rebuilder failed to account for `Var` or `Stretch` nodes. We have integration tests in `test/python/compiler/test_transpiler.py` that _in theory_ should have caught this, but in practice failed to because they are accidentally using all-to-all connectivity backends, so Sabre never runs in them. (cherry picked from commit 985bd7a) Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 28, 2025
…14493) * Fix Sabre rebuild with nested `Var` and `Stretch` (#14488) The `empty_dag` helper, used to construct control-flow blocks, in the rebuilder failed to account for `Var` or `Stretch` nodes. We have integration tests in `test/python/compiler/test_transpiler.py` that _in theory_ should have caught this, but in practice failed to because they are accidentally using all-to-all connectivity backends, so Sabre never runs in them. * Fix test if routing occurs --------- Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
rahaman-quantum
pushed a commit
to rahaman-quantum/qiskit
that referenced
this pull request
Jun 20, 2025
The `empty_dag` helper, used to construct control-flow blocks, in the rebuilder failed to account for `Var` or `Stretch` nodes. We have integration tests in `test/python/compiler/test_transpiler.py` that _in theory_ should have caught this, but in practice failed to because they are accidentally using all-to-all connectivity backends, so Sabre never runs in them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
empty_daghelper, used to construct control-flow blocks, in the rebuilder failed to account forVarorStretchnodes. We have integration tests intest/python/compiler/test_transpiler.pythat in theory should have caught this, but in practice failed to because they are accidentally using all-to-all connectivity backends, so Sabre never runs in them.Summary
Details and comments
This fixes the test failures that #14484 turned up.