Tidy up unnecessary all-to-all tests #14484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One or more of the following people are relevant to this code:
|
This was referenced May 28, 2025
`GenericBackendV2` defaults to explicit all-to-all connectivity. Many old test cases were somewhat mechanically changed to use `GenericBackendV2` without fixing the coupling map, resulting in many tests using large-scale all-to-all connectivity with an inefficient representation, for tests that do not require it. This commit changes all test-suite uses of `GenericBackendV2` with more than 10 qubits and all-to-all connectivity to restrict the connectivity. There is one exception - a VF2Layout scaling test with 27q all-to-all, where the large number of possibilities is a deliberate part of the test. Several tests that previously had `BackendV1` and `BackendV2` versions have one of the pair deleted, since `BackendV1` no longer exists, and all those tests had already been changed to use `BackendV2`. A further regression test that was dependent on the particulars of various randomisation seeds that are _long_ since out-of-date is also deleted, rather than blindly fixing its connectivity.
fb65ebc to
52d14b4
Compare
Pull Request Test Coverage Report for Build 15309283798Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
mtreinish
approved these changes
May 28, 2025
| if optimization_level == 3 and sys.platform == "win32": | ||
| self.skipTest( | ||
| "This test case triggers a bug in the eigensolver routine on windows. " | ||
| "See #10345 for more details." |
There was a problem hiding this comment.
Oh we should close this issue we're not using scipy or LAPACK for the weyl decomposition anymore. So if we have flakiness on Windows it's a different root cause and would warrant a new issue.
| seed_transpiler=2023_07_26, | ||
| backend = GenericBackendV2( | ||
| num_qubits=27, | ||
| coupling_map=CouplingMap.from_line(27), |
There was a problem hiding this comment.
This was a bit confusing at first, because the "v1" test had 16 qubits, while the v2 has 27. We're just running with the v2 version now which makes sense.
rahaman-quantum
pushed a commit
to rahaman-quantum/qiskit
that referenced
this pull request
Jun 20, 2025
`GenericBackendV2` defaults to explicit all-to-all connectivity. Many old test cases were somewhat mechanically changed to use `GenericBackendV2` without fixing the coupling map, resulting in many tests using large-scale all-to-all connectivity with an inefficient representation, for tests that do not require it. This commit changes all test-suite uses of `GenericBackendV2` with more than 10 qubits and all-to-all connectivity to restrict the connectivity. There is one exception - a VF2Layout scaling test with 27q all-to-all, where the large number of possibilities is a deliberate part of the test. Several tests that previously had `BackendV1` and `BackendV2` versions have one of the pair deleted, since `BackendV1` no longer exists, and all those tests had already been changed to use `BackendV2`. A further regression test that was dependent on the particulars of various randomisation seeds that are _long_ since out-of-date is also deleted, rather than blindly fixing its connectivity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GenericBackendV2defaults to explicit all-to-all connectivity. Many old test cases were somewhat mechanically changed to useGenericBackendV2without fixing the coupling map, resulting in many tests using large-scale all-to-all connectivity with an inefficient representation, for tests that do not require it.This commit changes all test-suite uses of
GenericBackendV2with more than 10 qubits and all-to-all connectivity to restrict the connectivity. There is one exception - a VF2Layout scaling test with 27q all-to-all, where the large number of possibilities is a deliberate part of the test.Several tests that previously had
BackendV1andBackendV2versions have one of the pair deleted, sinceBackendV1no longer exists, and all those tests had already been changed to useBackendV2. A further regression test that was dependent on the particulars of various randomisation seeds that are long since out-of-date is also deleted, rather than blindly fixing its connectivity.Summary
Details and comments
This finishes the job of #14483.