Integrate C API tests into new GHA workflow structure #14481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Qiskit#13474 we restructured our CI to be based solely on github actions. As part of that change a new workflow structure was introduced where there were `on-*.yml` files that enumerate the jobs run for each job trigger. For example, `on-pull-request.yml` lists all the jobs that run when a pull request is opened or updated. However, the C API tests were not integrated into this new structure as part of Qiskit#13474 as they were already running and that PR didn't want to change github actions usage that was already working. This commit is the follow up that updates the C API tests so they fit into the new structure and the jobs that are run are listed in the specific trigger sections.
|
One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 15298391107Details
💛 - Coveralls |
jakelishman
previously approved these changes
May 28, 2025
There was a problem hiding this comment.
I think we also need to update the branch-protection rules to include the C-API tests? We won't be able to do that til #14492 is in, though.
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 28, 2025
In #13474 we restructured our CI to be based solely on github actions. As part of that change a new workflow structure was introduced where there were `on-*.yml` files that enumerate the jobs run for each job trigger. For example, `on-pull-request.yml` lists all the jobs that run when a pull request is opened or updated. However, the C API tests were not integrated into this new structure as part of #13474 as they were already running and that PR didn't want to change github actions usage that was already working. This commit is the follow up that updates the C API tests so they fit into the new structure and the jobs that are run are listed in the specific trigger sections.
jakelishman
reviewed
May 28, 2025
jakelishman
approved these changes
May 28, 2025
rahaman-quantum
pushed a commit
to rahaman-quantum/qiskit
that referenced
this pull request
Jun 20, 2025
* Integrate C API tests into new GHA workflow structure In Qiskit#13474 we restructured our CI to be based solely on github actions. As part of that change a new workflow structure was introduced where there were `on-*.yml` files that enumerate the jobs run for each job trigger. For example, `on-pull-request.yml` lists all the jobs that run when a pull request is opened or updated. However, the C API tests were not integrated into this new structure as part of Qiskit#13474 as they were already running and that PR didn't want to change github actions usage that was already working. This commit is the follow up that updates the C API tests so they fit into the new structure and the jobs that are run are listed in the specific trigger sections. * Fix broken syntax --------- Co-authored-by: Jake Lishman <jake@binhbar.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #13474 we restructured our CI to be based solely on github actions. As part of that change a new workflow structure was introduced where there were
on-*.ymlfiles that enumerate the jobs run for each job trigger. For example,on-pull-request.ymllists all the jobs that run when a pull request is opened or updated. However, the C API tests were not integrated into this new structure as part of #13474 as they were already running and that PR didn't want to change github actions usage that was already working. This commit is the follow up that updates the C API tests so they fit into the new structure and the jobs that are run are listed in the specific trigger sections.Details and comments