Fix more spurious complex parts in circuit functions (backport #14431) #14455
Conversation
* Fix spurious complex part in circuit funcs * reno links (cherry picked from commit e7fa11d)
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
|
The tests added here only trigger the issue prior to #13278 -- so they don't actually check the changed behavior on |
Pull Request Test Coverage Report for Build 15443606152Details
💛 - Coveralls |
…#14431) (Qiskit#14455) * Fix more spurious complex parts in circuit functions (Qiskit#14431) * Fix spurious complex part in circuit funcs * reno links (cherry picked from commit e7fa11d) * Add qpy compat test * Fix black * Fix lint, don't import circuit library element on older qiskit version * Remove venv * Fix indentation * Fix tests * Fix import * Fix access * debug * Change test * Restore backwards compat test * Remove reno --------- Co-authored-by: Julien Gacon <jules.gacon@googlemail.com> Co-authored-by: ElePT <epenatap@gmail.com> Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>
Summary
@ElePT reported that #13643 came back for other circuits, too. This essentially affects circuits that use operators as inputs, which have coefficients of complex types. This problem does not appear on
main, I assume #13278 removes the 0 complex component. We could still consider to add this safetyguard tomain, but there's no way to break it right now that I'm aware of.This is an automatic backport of pull request #14431 done by [Mergify](https://mergify.com).