Fix alignment checks of stretch variables
#14330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We treat `stretch` as meaning that a lower-level compiler will be rescheduling to resolve the stretch, so we don't need to worry about the alignment ourselves.
|
One or more of the following people are relevant to this code:
|
kevinhartman
previously approved these changes
May 8, 2025
jakelishman
commented
May 8, 2025
| Circuits containing delays with stretches (see :meth:`.QuantumCircuit.add_stretch`) can now | ||
| successfully compile using the preset pass-managers (:func:`.transpile` and | ||
| :func:`.generate_preset_pass_manager`) when targetting a backend that has alignment constraints, | ||
| for example IBM Quantum Eagle devices like ``ibm_washington``. |
There was a problem hiding this comment.
Oh whoops, I meant ibm_sherbrooke - I think Washington got retired a few months ago?
There was a problem hiding this comment.
ibm_washington was retired in June 2023: https://docs.quantum.ibm.com/guides/retired-qpus
jakelishman
commented
May 8, 2025
releasenotes/notes/stretch-duration-alignments-cd8395bcc8f6cdd0.yaml
Outdated
Show resolved
Hide resolved
kevinhartman
approved these changes
May 8, 2025
Pull Request Test Coverage Report for Build 14911618568Details
💛 - Coveralls |
mergify bot
pushed a commit
that referenced
this pull request
May 8, 2025
* Fix alignment checks of `stretch` variables We treat `stretch` as meaning that a lower-level compiler will be rescheduling to resolve the stretch, so we don't need to worry about the alignment ourselves. * Use non-retired backend as an example (cherry picked from commit bf828a7)
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 9, 2025
* Fix alignment checks of `stretch` variables (#14330) * Fix alignment checks of `stretch` variables We treat `stretch` as meaning that a lower-level compiler will be rescheduling to resolve the stretch, so we don't need to worry about the alignment ourselves. * Use non-retired backend as an example (cherry picked from commit bf828a7) * Fix method name for 2.0. --------- Co-authored-by: Jake Lishman <jake.lishman@ibm.com> Co-authored-by: Kevin Hartman <kevin@hart.mn>
rahaman-quantum
pushed a commit
to rahaman-quantum/qiskit
that referenced
this pull request
Jun 20, 2025
* Fix alignment checks of `stretch` variables We treat `stretch` as meaning that a lower-level compiler will be rescheduling to resolve the stretch, so we don't need to worry about the alignment ourselves. * Use non-retired backend as an example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We treat
stretchas meaning that a lower-level compiler will be rescheduling to resolve the stretch, so we don't need to worry about the alignment ourselves.Summary
Details and comments
Fix #14264