-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Introduce PauliLindbladMap class #14328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Samuele Ferracin <sam.ferracin@ibm.com>
Co-authored-by: Samuele Ferracin <sam.ferracin@ibm.com>
303d8a4
to
211ed40
Compare
…s are not writeable
Closing to be replaced by a new PR after substantial changes to the base branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
mod: primitives
Related to the Primitives module
mod: quantum info
Related to the Quantum Info module (States & Operators)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR depends on #14283
This adds the
PauliLindbladMap
class toquantum_info
. This class stores very similar data toSparseObservable
, but the list of operators is now stored within theQubitSparsePauliList
introduced in #14283.It also adds the "derived" properties:
gamma
- the overall gamma of the map.probabilities
- the probability of application for each Pauli operator in the pseudo-probabilistic product representation.non_negative_rates
- a vector of booleans evaluating rate >= 0 for each rate in rates.The above are "derived" in the sense that they are functions of the
rates
. As a result they have been setup to be non-writable, and to be updated ifrates
is ever mutated.Details and comments
The one thing I'm uncertain about is that there is a lot of overlap between the docs of
PauliLindbladMap
andQubitSparsePauliList
in terms of thePauli
symbol/bit property. Currently the internally storedQubitSparsePauliList
is not accessible fromPauliLindbladMap
- the properties/methods ofPauliLindbladMap
are set up so that it looks like all the information inQubitSparsePauliList
(paulis
,indices
,boundaries
) is directly stored byPauliLindbladMap
. With this current interface, it doesn't seem to me make sense to reference back toQubitSparsePauliList
if there is no explicit connection between the classes. I think I'm fine with this but am open to suggestions.