Skip to content

Fix qpy for MCMTGate (backport #14096) #14325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 8, 2025

Summary

This PR fixes #13965.

Details and comments

qpy had to save base_gate for MCMTGate, which didn't. I only added MCMTGate to custom operations because _read_custom_operations and _write_custom_operation already handled base_gate.


This is an automatic backport of pull request #14096 done by [Mergify](https://mergify.com).

* Add MCMXGate to custom operations

* Add test and reno

---------

Co-authored-by: Shelly Garion <46566946+ShellyGarion@users.noreply.github.com>
(cherry picked from commit 0f7c6f6)
@mergify mergify bot requested a review from a team as a code owner May 8, 2025 11:49
@mergify mergify bot mentioned this pull request May 8, 2025
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core
  • @mtreinish
  • @nkanazawa1989

@github-actions github-actions bot added Changelog: Bugfix Include in the "Fixed" section of the changelog Community PR PRs from contributors that are not 'members' of the Qiskit repo labels May 8, 2025
@ElePT ElePT added this to the 1.4.3 milestone May 8, 2025
@ElePT ElePT enabled auto-merge May 8, 2025 11:52
@ElePT ElePT added this pull request to the merge queue May 8, 2025
Merged via the queue into stable/1.4 with commit 0dded20 May 8, 2025
19 of 20 checks passed
@jakelishman jakelishman deleted the mergify/bp/stable/1.4/pr-14096 branch June 9, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog Community PR PRs from contributors that are not 'members' of the Qiskit repo
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants