-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Remove dateutil as a requirement #14395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The dateutil package was previously used by the BackendV1 models to parse datetime information that was passed into the from_dict() constructors for those objects. Since Qiskit 2.0.0 those objects haven't been part of Qiskit anymore as BackendV1 was removed in that release following it's deprecation period nothing is using the library anymore in Qiskit. However the dateutil library was not removed as a dependency at the time of removal. This commit corrects the oversight and removes the library as a dependency.
One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 15140190827Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes complete sense to me to remove dependencies are no longer used anywhere in the code, so this looks great. Just some minor nits about the release notes.
Co-authored-by: Alexander Ivrii <alexi@il.ibm.com>
* Remove dateutil as a requirement The dateutil package was previously used by the BackendV1 models to parse datetime information that was passed into the from_dict() constructors for those objects. Since Qiskit 2.0.0 those objects haven't been part of Qiskit anymore as BackendV1 was removed in that release following it's deprecation period nothing is using the library anymore in Qiskit. However the dateutil library was not removed as a dependency at the time of removal. This commit corrects the oversight and removes the library as a dependency. * Update releasenotes/notes/no-dateutil-ca2ca5f5a75fbb22.yaml Co-authored-by: Alexander Ivrii <alexi@il.ibm.com> --------- Co-authored-by: Alexander Ivrii <alexi@il.ibm.com>
* Remove dateutil as a requirement The dateutil package was previously used by the BackendV1 models to parse datetime information that was passed into the from_dict() constructors for those objects. Since Qiskit 2.0.0 those objects haven't been part of Qiskit anymore as BackendV1 was removed in that release following it's deprecation period nothing is using the library anymore in Qiskit. However the dateutil library was not removed as a dependency at the time of removal. This commit corrects the oversight and removes the library as a dependency. * Update releasenotes/notes/no-dateutil-ca2ca5f5a75fbb22.yaml Co-authored-by: Alexander Ivrii <alexi@il.ibm.com> --------- Co-authored-by: Alexander Ivrii <alexi@il.ibm.com>
Summary
The dateutil package was previously used by the BackendV1 models to parse datetime information that was passed into the from_dict() constructors for those objects. Since Qiskit 2.0.0 those objects haven't been part of Qiskit anymore as BackendV1 was removed in that release following it's deprecation period nothing is using the library anymore in Qiskit. However the dateutil library was not removed as a dependency at the time of removal. This commit corrects the oversight and removes the library as a dependency.
Details and comments