Remove symengine from the requirements list #14389
Merged
+46
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Qiskit#13278 we removed our dependency on symengine and replaced it with our own symbolic engine. However that PR neglected to remove symengine from the requirements list. This commit corrects this oversight and removes it from the requirements list. It also updates the release notes to make them a bit more prescise and document the change in requirements and potential behavior differences with the new engine.
|
One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 15171648126Details
💛 - Coveralls |
|
I think we can actually drop sympy from the requirements list too. I'll give a try and push up a commit if we can. EDIT: I looked into this, it is possible to remove but there is some more work needed to address the internals of a couple functions to remove a dependency there. I'll work on this in a parallel PR. |
550cf36 to
6980c83
Compare
Cryoris
reviewed
May 19, 2025
Cryoris
reviewed
May 19, 2025
During QPY deserialization of old payloads that include pulse schedules we are unable to construct the pulse schedule from the payload. For circuits that include pulse gates the strategy for loading those payloads is to emit a warning that the pulse component will be omitted and create the rest of the circuit like normal. To do this the qpy deserialization has to read the size of the payload to seek to the right position. However we don't need to actually parse the expression because it's never used. This commit removes the parsing step it is unnecessary after we do the read that will seek the cursor appropriately.
Cryoris
reviewed
May 21, 2025
releasenotes/notes/parameter-expression-rs-6fddbb2556b7e1f7.yaml
Outdated
Show resolved
Hide resolved
Cryoris
reviewed
May 21, 2025
Co-authored-by: Julien Gacon <gaconju@gmail.com>
Cryoris
approved these changes
May 22, 2025
rahaman-quantum
pushed a commit
to rahaman-quantum/qiskit
that referenced
this pull request
Jun 20, 2025
* Remove symengine from the requirements list In Qiskit#13278 we removed our dependency on symengine and replaced it with our own symbolic engine. However that PR neglected to remove symengine from the requirements list. This commit corrects this oversight and removes it from the requirements list. It also updates the release notes to make them a bit more prescise and document the change in requirements and potential behavior differences with the new engine. * Add new optional extra variant for symengine for QPY * Stop parsing sympy and symengine pulse expressions During QPY deserialization of old payloads that include pulse schedules we are unable to construct the pulse schedule from the payload. For circuits that include pulse gates the strategy for loading those payloads is to emit a warning that the pulse component will be omitted and create the rest of the circuit like normal. To do this the qpy deserialization has to read the size of the payload to seek to the right position. However we don't need to actually parse the expression because it's never used. This commit removes the parsing step it is unnecessary after we do the read that will seek the cursor appropriately. * Update releasenotes/notes/parameter-expression-rs-6fddbb2556b7e1f7.yaml Co-authored-by: Julien Gacon <gaconju@gmail.com> * Remove unused arguments --------- Co-authored-by: Julien Gacon <gaconju@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #13278 we removed our dependency on symengine and replaced it with our own symbolic engine. However that PR neglected to remove symengine from the requirements list. This commit corrects this oversight and removes it from the requirements list. It also updates the release notes to make them a bit more precise and document the change in requirements and potential behavior differences with the new engine.
Details and comments