added get_qpy_version to retrieve qpy version #14212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
|
|
ElePT
reviewed
Apr 16, 2025
There was a problem hiding this comment.
Hi @arujjval, thanks for your contribution! When someone develops a new feature we require the following items:
- The feature must be tested, I suggest adding a unit test in the following file:
test/python/qpy/test_circuit_load_from_qpy.py - If it's a user-facing feature, it must be documented. For this, you should add it to the API docs together with dump and load: https://github.com/Qiskit/qiskit/blob/main/qiskit/qpy/__init__.py#L100
- Finally, you should add a releasenote following the instructions in the contribution guidelines
If you have any question, let us know.
|
@ElePT Thanks for the help! I have made changes like you asked. |
mtreinish
reviewed
May 8, 2025
Pull Request Test Coverage Report for Build 15395920071Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
mtreinish
reviewed
May 16, 2025
This commit reworks the internal logic to ensure we're not advancing the file cursor on exiting the function. If we didn't seek back the 7 bytes we read this would be forcing pretty much every conceivable usage of would be using this as a check and then loading the qpy based on the result. This behavior is then added to the docstring and a test is added to assert this behavior is part of the api.
mtreinish
approved these changes
Jun 2, 2025
raynelfss
approved these changes
Jun 2, 2025
rahaman-quantum
pushed a commit
to rahaman-quantum/qiskit
that referenced
this pull request
Jun 20, 2025
* added get_qpy_version * added test for get_qpy_version * updated test_qpy_versions with different version numbers * resolved lint errors * Apply suggestions from code review * Do not advance cursor on exit This commit reworks the internal logic to ensure we're not advancing the file cursor on exiting the function. If we didn't seek back the 7 bytes we read this would be forcing pretty much every conceivable usage of would be using this as a check and then loading the qpy based on the result. This behavior is then added to the docstring and a test is added to assert this behavior is part of the api. --------- Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#14201
Summary
To get the qpy version, I have added a new function, "get_qpy_version," according to the suggestion given in the issue.
Comments
I am unsure where to write the tests for this if needed. Is there any guide about writing tests?