Wrote ObservablesArray.apply_layout and some additional methods
#14289
Conversation
|
One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 14892081928Details
💛 - Coveralls |
| for ndi, obs in np.ndenumerate(self._array): | ||
| new_arr[ndi] = obs.apply_layout(layout, num_qubits) | ||
|
|
||
| return ObservablesArray(new_arr) |
There was a problem hiding this comment.
I chose not to set validate to False, only to be on the safe side, but I actually don't see a real reason. What do you think?
There was a problem hiding this comment.
I think we should not validate in the constructor when making new instances in method implementations
| arr2 = np.atleast_1d(other._array).flat | ||
|
|
||
| for obs1, obs2 in zip(arr1, arr2): | ||
| if (obs1 - obs2).simplify(tol) != SparseObservable.zero(self.num_qubits): |
There was a problem hiding this comment.
nit: the creation of the zero array can be moved outside of the loop.
|
|
||
| n_qubits = self.num_qubits | ||
| if isinstance(layout, TranspileLayout): | ||
| n_qubits = len(layout._output_qubit_list) |
There was a problem hiding this comment.
We shouldn't be using private attributes of other classes. Is there another way to fetch this information?
There was a problem hiding this comment.
It seems like just len(layout) is sufficient?
| for ndi, obs in np.ndenumerate(self._array): | ||
| new_arr[ndi] = obs.apply_layout(layout, num_qubits) | ||
|
|
||
| return ObservablesArray(new_arr) |
There was a problem hiding this comment.
I think we should not validate in the constructor when making new instances in method implementations
Co-authored-by: Ian Hincks <ian.hincks@gmail.com>
Co-authored-by: Ian Hincks <ian.hincks@gmail.com>
Co-authored-by: Ian Hincks <ian.hincks@gmail.com>
Co-authored-by: Ian Hincks <ian.hincks@gmail.com>
Co-authored-by: Ian Hincks <ian.hincks@gmail.com>
Co-authored-by: Ian Hincks <ian.hincks@gmail.com>
Co-authored-by: Ian Hincks <ian.hincks@gmail.com>
Co-authored-by: Ian Hincks <ian.hincks@gmail.com>
Summary
Addresses part of #14129
Details and comments
Added the following methods to
ObservablesArray:apply_layoutequivalentcopyAlso added
SparseObservabletoObservableLikeand a test to verify the workflow with the estimator.