Skip to content

Fix missing Qk prefix for C ExitCode #14119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 28, 2025
Merged

Fix missing Qk prefix for C ExitCode #14119

merged 2 commits into from
Mar 28, 2025

Conversation

Cryoris
Copy link
Contributor

@Cryoris Cryoris commented Mar 28, 2025

Summary

Missed a Qk prefix for the ExitCode enum class, which should be called QkExitCode. This sort of problem will likely keep popping up since we're manually adding this prefix, until we get a solution like mozilla/cbindgen#1061.

@Cryoris Cryoris added Changelog: None Do not include in changelog C API Related to the C API labels Mar 28, 2025
@Cryoris Cryoris added this to the 2.0.0 milestone Mar 28, 2025
@Cryoris Cryoris requested a review from a team as a code owner March 28, 2025 11:28
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@coveralls
Copy link

Pull Request Test Coverage Report for Build 14127953773

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 24 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.03%) to 88.063%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 94.23%
crates/qasm2/src/lex.rs 5 91.73%
crates/qasm2/src/parse.rs 18 96.22%
Totals Coverage Status
Change from base Build 14125599115: -0.03%
Covered Lines: 72738
Relevant Lines: 82598
💛 - Coveralls

@mtreinish mtreinish added this pull request to the merge queue Mar 28, 2025
@mtreinish mtreinish added the stable backport potential The bug might be minimal and/or import enough to be port to stable label Mar 28, 2025
Merged via the queue into Qiskit:main with commit 8c21753 Mar 28, 2025
21 checks passed
mergify bot pushed a commit that referenced this pull request Mar 28, 2025
@Cryoris @mergify
missing ExitCode->QkExitCode (#14119)
4d607a7 
(cherry picked from commit 8c21753)
@mergify mergify bot mentioned this pull request Mar 28, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Mar 28, 2025
@mergify @Cryoris
missing ExitCode->QkExitCode (#14119) (#14123)
9cf2d99 
(cherry picked from commit 8c21753)

Co-authored-by: Julien Gacon <jules.gacon@googlemail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtreinish mtreinish mtreinish approved these changes

Assignees
No one assigned
Labels
C API Related to the C API Changelog: None Do not include in changelog stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Cryoris @qiskit-bot @coveralls @mtreinish