Skip to content

Fix qpy for MCMTGate (backport #14096) #14118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2025
Merged

Fix qpy for MCMTGate (backport #14096) #14118

merged 1 commit into from
Mar 28, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 28, 2025

Summary

This PR fixes #13965.

Details and comments

qpy had to save base_gate for MCMTGate, which didn't. I only added MCMTGate to custom operations because _read_custom_operations and _write_custom_operation already handled base_gate.

This is an automatic backport of pull request #14096 done by [Mergify](https://mergify.com).

@ksk0629 @ShellyGarion @mergify
Fix qpy for MCMTGate (#14096)
33e9fc1 
* Add MCMXGate to custom operations

* Add test and reno

---------

Co-authored-by: Shelly Garion <46566946+ShellyGarion@users.noreply.github.com>
(cherry picked from commit 0f7c6f6)
@mergify mergify bot requested a review from a team as a code owner March 28, 2025 09:11
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core
  • @mtreinish
  • @nkanazawa1989

@github-actions github-actions bot added Changelog: Bugfix Include in the "Fixed" section of the changelog Community PR PRs from contributors that are not 'members' of the Qiskit repo labels Mar 28, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 14125625899

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 16 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.001%) to 88.079%
Files with Coverage Reduction New Missed Lines %
crates/accelerate/src/unitary_synthesis.rs 1 94.79%
crates/qasm2/src/lex.rs 3 93.23%
crates/qasm2/src/parse.rs 12 97.15%
Totals Coverage Status
Change from base Build 14111795440: -0.001%
Covered Lines: 72743
Relevant Lines: 82588
💛 - Coveralls

@ShellyGarion ShellyGarion added this pull request to the merge queue Mar 28, 2025
Merged via the queue into stable/2.0 with commit b179a3a Mar 28, 2025
23 checks passed
@ShellyGarion ShellyGarion added this to the 2.0.0 milestone Mar 28, 2025
@jakelishman jakelishman deleted the mergify/bp/stable/2.0/pr-14096 branch June 9, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElePT ElePT ElePT approved these changes

Assignees
No one assigned
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog Community PR PRs from contributors that are not 'members' of the Qiskit repo
Projects
Contributor Monitoring
Status: Done
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@qiskit-bot @coveralls @ElePT @ShellyGarion @ksk0629