Skip to content

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 28, 2025

e.g. why we use different gate types and what's the advantages

Summary

With #13046 the designated workflow with the circuit library changed. This PR adds a section to the docs explaining this new structure. While not fully done, I'm already opening this draft PR for people to have a look at the text.

Details and comments

This includes some other minor changes:

  • add a TOC for the different sections
  • consistently sort the standard gates (before this was partially sorted, partially chaotic)
  • move the documentation of get_standard_gate_name_mapping under Standard gates
  • always mention the circuit functions and gates before the old circuits

To do

  • Add some more examples to the sections
  • Move the template circuits to a separate page
  • Can we find a better name/structure for "particular quantum circuits"?

This is an automatic backport of pull request #13520 done by [Mergify](https://mergify.com).

* Explain circlib design

e.g. why we use different gate types and what's the advantages

* separate old circuits and new gates

* alt text & broken links

* Apply suggestions from code review

Thank you Elena!

Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>

* more review comments

---------

Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>
(cherry picked from commit 4675335)
@mergify mergify bot requested a review from a team as a code owner March 28, 2025 08:48
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @Cryoris
  • @Qiskit/terra-core
  • @ajavadia

@github-actions github-actions bot added documentation Something is not clear or an error documentation Changelog: None Do not include in changelog labels Mar 28, 2025
@github-actions github-actions bot added this to the 2.0.0 milestone Mar 28, 2025
@ElePT ElePT enabled auto-merge March 28, 2025 08:58
@coveralls
Copy link

Pull Request Test Coverage Report for Build 14125242635

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 19 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.02%) to 88.062%

Files with Coverage Reduction New Missed Lines %
crates/accelerate/src/unitary_synthesis.rs 1 94.79%
crates/qasm2/src/expr.rs 1 94.23%
crates/qasm2/src/lex.rs 5 91.98%
crates/qasm2/src/parse.rs 12 96.68%
Totals Coverage Status
Change from base Build 14111795440: -0.02%
Covered Lines: 72725
Relevant Lines: 82584

💛 - Coveralls

@ElePT ElePT added this pull request to the merge queue Mar 28, 2025
Merged via the queue into stable/2.0 with commit 8c4ad24 Mar 28, 2025
23 checks passed
@jakelishman jakelishman deleted the mergify/bp/stable/2.0/pr-13520 branch June 9, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog documentation Something is not clear or an error documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants