Skip to content

Fix circuit-metadata propagation in SabreLayout (backport #14186) #14190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 9, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 7, 2025

Summary

This has been a bug since gh-10712, but wasn't caught by the integration test in the test suite because that constructs a because the circuit has a perfect layout, so the layout stage was short-circuiting out after VF2.

Details and comments

I caught this by making a buggy version of VF2 that doesn't recognise Target 2q links without a defined error.


This is an automatic backport of pull request #14186 done by Mergify.

This has been a bug since gh-10712, but wasn't caught by the integration
test in the test suite because the circuit has a perfect layout, so the
layout stage was short-circuiting out after VF2.

(cherry picked from commit 2504bde)

# Conflicts:
#	qiskit/transpiler/passes/layout/sabre_layout.py
@mergify mergify bot requested a review from a team as a code owner April 7, 2025 17:03
@mergify mergify bot added the conflicts used by mergify when there are conflicts in a port label Apr 7, 2025
Copy link
Contributor Author

mergify bot commented Apr 7, 2025

Cherry-pick of 2504bde has failed:

On branch mergify/bp/stable/1.4/pr-14186
Your branch is up to date with 'origin/stable/1.4'.

You are currently cherry-picking commit 2504bde2f.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   releasenotes/notes/fix-sabre-metadata-88e2a63c02810e61.yaml
	modified:   test/python/transpiler/test_preset_passmanagers.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   qiskit/transpiler/passes/layout/sabre_layout.py

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@github-actions github-actions bot added Changelog: Bugfix Include in the "Fixed" section of the changelog mod: transpiler Issues and PRs related to Transpiler labels Apr 7, 2025
@github-actions github-actions bot added this to the 1.4.3 milestone Apr 7, 2025
mtreinish
mtreinish previously approved these changes Apr 7, 2025
@mtreinish mtreinish enabled auto-merge April 7, 2025 21:10
@coveralls
Copy link

Pull Request Test Coverage Report for Build 14343517528

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 11 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.02%) to 88.814%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 5 92.48%
crates/qasm2/src/parse.rs 6 97.62%
Totals Coverage Status
Change from base Build 14246930165: 0.02%
Covered Lines: 79460
Relevant Lines: 89468

💛 - Coveralls

@mtreinish mtreinish added this pull request to the merge queue Apr 8, 2025
Merged via the queue into stable/1.4 with commit 1049ece Apr 9, 2025
19 checks passed
@mtreinish mtreinish deleted the mergify/bp/stable/1.4/pr-14186 branch April 29, 2025 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog conflicts used by mergify when there are conflicts in a port mod: transpiler Issues and PRs related to Transpiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants