Fix circuit-metadata propagation in SabreLayout
(backport #14186)
#14190
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This has been a bug since gh-10712, but wasn't caught by the integration test in the test suite because that constructs a because the circuit has a perfect layout, so the layout stage was short-circuiting out after VF2.
Details and comments
I caught this by making a buggy version of VF2 that doesn't recognise
Target
2q links without a defined error.This is an automatic backport of pull request #14186 done by Mergify.