Fix pickle and repr for Duration.
#14174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One or more of the following people are relevant to this code:
|
Duration.
Pull Request Test Coverage Report for Build 14269579109Details
💛 - Coveralls |
raynelfss
approved these changes
Apr 4, 2025
Comment on lines
+177
to
+197
| m.add( | ||
| "Duration_ns", | ||
| duration::Duration::type_object(m.py()).getattr("ns")?, | ||
| )?; | ||
| m.add( | ||
| "Duration_us", | ||
| duration::Duration::type_object(m.py()).getattr("us")?, | ||
| )?; | ||
| m.add( | ||
| "Duration_ms", | ||
| duration::Duration::type_object(m.py()).getattr("ms")?, | ||
| )?; | ||
| m.add( | ||
| "Duration_s", | ||
| duration::Duration::type_object(m.py()).getattr("s")?, | ||
| )?; | ||
| m.add( | ||
| "Duration_dt", | ||
| duration::Duration::type_object(m.py()).getattr("dt")?, | ||
| )?; | ||
|
|
There was a problem hiding this comment.
I'm a bit surprised that this step is needed. But I guess it makes some sense considering that pickle will try to access the class objects based on their import paths.
There was a problem hiding this comment.
Yeah, I was too, though I think it makes sense that PyO3 doesn't expose these by default. Users should not be constructing Duration_xxs directly, so I don't think the names have a good case for being exposed by the containing module, other than for serialization (which PyO3 doesn't explicitly support).
mergify bot
pushed a commit
that referenced
this pull request
Apr 8, 2025
(cherry picked from commit b0bc6d8)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 8, 2025
* Fix pickle and repr for Duration. (#14174) (cherry picked from commit b0bc6d8) * Update releasenotes/notes/fix-duration-props-0543fe1d5e6e2820.yaml * Update releasenotes/notes/fix-duration-props-0543fe1d5e6e2820.yaml --------- Co-authored-by: Kevin Hartman <kevin@hart.mn> Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds missing Python pickle support for the new
Durationtype added in Qiskit 2.0.Details and comments
To get this working, I needed to manually register the PyO3 generated
Duration_xxPython classes at the module level, sincepicklelooks for them during deserialization. I'm not sure if there's a better way, but I'm open to suggestions if you can think of something cleaner. Pickle doesn't have explicit support in PyO3, so we're lucky to have any working solution here.While fixing this, I also noticed that
__repr__was defined inside animplblock that wasn't decorated with#[pymethods], meaning it wasn't actually being used before. That's fixed here too.Fixes #14169