Skip to content

[POC] Moving the Target's gate_map source of truth to Rust. #14173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

[POC] Moving the Target's gate_map source of truth to Rust. #14173

wants to merge 5 commits into from

Conversation

raynelfss
Copy link
Contributor

@raynelfss raynelfss commented Apr 3, 2025 •
edited
Loading

Summary

  • Create two parallel structs GateMap and PropsMap to represent the complex mapping happening in GateMap and achieve two things:
    • Make the python side mapping no longer be exposed publicly.
    • Make the mapping python independent and rebuildable upon request.
  • This commit is built on several branches that perform additions to the target and this branch will either be superceded or heavily rebased upon further review.

Details and comments

Tasks

  • Implement python gate map to be rebuildable from rust.
  • Test roundtrip (Python <---> Rust)
  • Rebasing

Pre-requisites

@coveralls
Copy link

coveralls commented Apr 3, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 14642756012

Details

  • 247 of 271 (91.14%) changed or added relevant lines in 3 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.07%) to 88.001%
Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/transpiler/target.py 3 4 75.0%
crates/accelerate/src/target_transpiler/synched_map.rs 153 176 86.93%
Files with Coverage Reduction New Missed Lines %
crates/accelerate/src/unitary_synthesis.rs 1 94.78%
crates/qasm2/src/lex.rs 6 92.23%
Totals Coverage Status
Change from base Build 14640289610: 0.07%
Covered Lines: 74321
Relevant Lines: 84455
💛 - Coveralls

This was referenced Apr 8, 2025
Closed
Closed
@raynelfss raynelfss force-pushed the target-gate-map branch 5 times, most recently from 946d6e1 to 0083ce0 Compare April 16, 2025 20:28
@raynelfss raynelfss added this to the 2.1.0 milestone Apr 21, 2025
@raynelfss raynelfss mentioned this pull request Apr 21, 2025
Merged
2 tasks
@raynelfss raynelfss mentioned this pull request Apr 23, 2025
Merged
@raynelfss
To be rebased
702be33
@raynelfss
Initial: Move the source of truth of the Target gate map to Rust.
d1e3f95 
- Create two parallel structs `GateMap` and `PropsMap` to represent the complex mapping happening in `GateMap` and achieve two things:
    - Make the python side mapping no longer be exposed publicly.
    - Make the mapping python independent and rebuildable upon request.
- This commit is built on several branches that perform additions to the target and this branch will either be superceded or heavily rebased upon further review.
@raynelfss
Refactor: GateMap and PropsMap are now SynchedMap<K, V> to allo…
19dd4ea 
…w the structure to be re-used.

- Since `Qargs` already implements its custom version of `IntoPyObject`, we are free to just make the custom mappings fully generic.
- `SynchedMap<K, V>` implements a cached `PyDict` that loads modifications done on the rust side back to Python. This synchronization does not apply to changes done in Python just yet. Will be saved for a follow-up.
@raynelfss
Refactor: Rename "gate_map.rs" to "synched_map.rs"
25565f0
@mtreinish mtreinish removed this from the 2.1.0 milestone May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raynelfss @coveralls @mtreinish