-
Notifications
You must be signed in to change notification settings - Fork 2.6k
HLS plugin for new MCX Decompositions #14143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HLS plugin for new MCX Decompositions #14143
Conversation
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 14247565305Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
I am unsure where the linter error is coming from. |
…tar_gidney' into hls_plugin_mcx_khattar_gidney
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@patelvyom - I very much appreciate your contribution to qiskit.
The documentation looks well as well as the tests. I have a minor comment on the release notes.
@alexanderivrii - could you also review this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, this looks really great!
for synthesis_method in [ | ||
MCXSynthesisNCleanM15, | ||
MCXSynthesisNDirtyI15, | ||
MCXSynthesis2CleanKG24, | ||
MCXSynthesis2DirtyKG24, | ||
MCXSynthesis1CleanKG24, | ||
MCXSynthesis1DirtyKG24, | ||
MCXSynthesis1CleanB95, | ||
]: | ||
if ( | ||
decomposition := synthesis_method().run( | ||
high_level_object, coupling_map, target, qubits, **options | ||
) | ||
) is not None: | ||
return decomposition |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really nice!
Summary
Add HLS passes for recently added
synth_mcx_2_clean_kg24, synth_mcx_2_dirty_kg24, synth_mcx_1_clean_kg24, synth_mcx_1_dirty_kg24
in #13922.