Skip to content

Conversation

ksk0629
Copy link
Contributor

@ksk0629 ksk0629 commented Mar 25, 2025

Summary

This PR fixes #13965.

Details and comments

qpy had to save base_gate for MCMTGate, which didn't. I only added MCMTGate to custom operations because _read_custom_operations and _write_custom_operation already handled base_gate.

@ksk0629 ksk0629 requested a review from a team as a code owner March 25, 2025 18:12
@qiskit-bot qiskit-bot added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Mar 25, 2025
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core
  • @mtreinish
  • @nkanazawa1989

@CLAassistant
Copy link

CLAassistant commented Mar 25, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ElePT ElePT added the Changelog: Bugfix Include in the "Fixed" section of the changelog label Mar 26, 2025
@coveralls
Copy link

coveralls commented Mar 26, 2025

Pull Request Test Coverage Report for Build 14123004376

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 16 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.009%) to 88.082%

Files with Coverage Reduction New Missed Lines %
crates/accelerate/src/unitary_synthesis.rs 1 94.79%
crates/qasm2/src/lex.rs 3 92.48%
crates/qasm2/src/parse.rs 12 97.15%
Totals Coverage Status
Change from base Build 14109208575: -0.009%
Covered Lines: 72754
Relevant Lines: 82598

💛 - Coveralls

Copy link
Member

@ShellyGarion ShellyGarion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution to qiskit

@ShellyGarion ShellyGarion added the stable backport potential The bug might be minimal and/or import enough to be port to stable label Mar 27, 2025
@ShellyGarion ShellyGarion enabled auto-merge March 27, 2025 10:46
@ShellyGarion ShellyGarion added this pull request to the merge queue Mar 28, 2025
Merged via the queue into Qiskit:main with commit 0f7c6f6 Mar 28, 2025
20 checks passed
mergify bot pushed a commit that referenced this pull request Mar 28, 2025
* Add MCMXGate to custom operations

* Add test and reno

---------

Co-authored-by: Shelly Garion <46566946+ShellyGarion@users.noreply.github.com>
(cherry picked from commit 0f7c6f6)
github-merge-queue bot pushed a commit that referenced this pull request Mar 28, 2025
* Add MCMXGate to custom operations

* Add test and reno

---------

Co-authored-by: Shelly Garion <46566946+ShellyGarion@users.noreply.github.com>
(cherry picked from commit 0f7c6f6)

Co-authored-by: ksk <65692273+ksk0629@users.noreply.github.com>
@ShellyGarion ShellyGarion added this to the 2.0.0 milestone Mar 28, 2025
@raynelfss raynelfss mentioned this pull request Mar 28, 2025
4 tasks
@ElePT
Copy link
Contributor

ElePT commented May 8, 2025

@Mergifyio backport stable/1.4

Copy link
Contributor

mergify bot commented May 8, 2025

backport stable/1.4

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 8, 2025
* Add MCMXGate to custom operations

* Add test and reno

---------

Co-authored-by: Shelly Garion <46566946+ShellyGarion@users.noreply.github.com>
(cherry picked from commit 0f7c6f6)
@ElePT ElePT modified the milestones: 2.0.0, 1.4.3 May 8, 2025
github-merge-queue bot pushed a commit that referenced this pull request May 8, 2025
* Add MCMXGate to custom operations

* Add test and reno

---------


(cherry picked from commit 0f7c6f6)

Co-authored-by: ksk <65692273+ksk0629@users.noreply.github.com>
Co-authored-by: Shelly Garion <46566946+ShellyGarion@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog Community PR PRs from contributors that are not 'members' of the Qiskit repo stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

QPY fails to serialize MCMTGate gate
6 participants