Skip to content

Conversation

OneHitKing
Copy link
Contributor

Added the second parameter φ that determines the axis of rotation in the x-y plane.

@OneHitKing OneHitKing requested a review from a team as a code owner March 24, 2025 12:36
@qiskit-bot qiskit-bot added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Mar 24, 2025
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @Cryoris
  • @Qiskit/terra-core
  • @ajavadia

@CLAassistant
Copy link

CLAassistant commented Mar 24, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ShellyGarion ShellyGarion linked an issue Mar 24, 2025 that may be closed by this pull request
@ShellyGarion ShellyGarion added documentation Something is not clear or an error documentation Changelog: None Do not include in changelog stable backport potential The bug might be minimal and/or import enough to be port to stable labels Mar 24, 2025
Copy link
Member

@alexanderivrii alexanderivrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick fix!

@jakelishman jakelishman changed the title Added the second parameter Added the second parameter to RGate Mar 24, 2025
@jakelishman
Copy link
Member

@Mergifyio backport stable/1.4 stable/2.0

Copy link
Contributor

mergify bot commented Mar 24, 2025

backport stable/1.4 stable/2.0

✅ Backports have been created

@alexanderivrii alexanderivrii added this pull request to the merge queue Mar 24, 2025
Merged via the queue into Qiskit:main with commit 3b4a39d Mar 24, 2025
21 checks passed
mergify bot pushed a commit that referenced this pull request Mar 24, 2025
(cherry picked from commit 3b4a39d)
mergify bot pushed a commit that referenced this pull request Mar 24, 2025
(cherry picked from commit 3b4a39d)
github-merge-queue bot pushed a commit that referenced this pull request Mar 24, 2025
(cherry picked from commit 3b4a39d)

Co-authored-by: Zephyrex <pranavjha091106@gmail.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 14035422432

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 30 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.03%) to 88.043%

Files with Coverage Reduction New Missed Lines %
crates/accelerate/src/unitary_synthesis.rs 1 94.79%
crates/qasm2/src/expr.rs 1 94.23%
crates/qasm2/src/lex.rs 4 92.98%
crates/qasm2/src/parse.rs 24 96.22%
Totals Coverage Status
Change from base Build 14034596400: -0.03%
Covered Lines: 72602
Relevant Lines: 82462

💛 - Coveralls

github-merge-queue bot pushed a commit that referenced this pull request Mar 24, 2025
(cherry picked from commit 3b4a39d)

Co-authored-by: Zephyrex <pranavjha091106@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog Community PR PRs from contributors that are not 'members' of the Qiskit repo documentation Something is not clear or an error documentation stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

RGate documentation
7 participants