-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Fix default optimization level in comment #14045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@radams78: thanks for the change. You'll need to sign the contributor-licensing agreement (see the bot's comment above) before we can accept this for merge.
(Strictly, I imagine that this commit isn't material to IP right assignment, but good luck teaching a bot that...)
Pull Request Test Coverage Report for Build 13922990398Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
No worries - I can see you've signed it in the CLA admin panel, so I've kicked the bot to have another look at the PR. Sometimes it gets a bit stuck - I'll give it an hour or so and hopefully it'll sort itself out. |
@radams78: ah, I see the problem on closer inspection. You made the commit in this PR with an email that's not associated with your @radams78 account, but actually @robin-test-stack. You'll either need to sign the CLA with that account to make the bot happy, or you need to force-push over this branch with a new commit that's associated with an email address attached to @radams78 (I'm assuming of course that you made the first commit - if it was somebody else, they need to sign the CLA). (edit: or reassign the email addresses in GitHub if your intent is to have your |
Sorry about that. Done now. (How much work can it be to change one character in a comment?) |
Ha, sorry that was a bit of a faff. Thanks for coming back to it. On the plus side, at least it shouldn't be a problem again if you use either account, and that should go for any Qiskit repo - the bot aggregates license signings on any Qiskit repo that uses the CLA (which tbf is probably all of them). |
Summary
Change default optimization level in comment from 1 to 2.
Details and comments
The comment on line 252 of transpiler.py said "Take optimization level from the configuration or 1 as default." This is incorrect - the default is 2. I have corrected the comment.
qiskit/qiskit/compiler/transpiler.py
Line 252 in 219dec7
This fixes issue 14036:
#14036