Skip to content

Conversation

radams78
Copy link
Contributor

Summary

Change default optimization level in comment from 1 to 2.

Details and comments

The comment on line 252 of transpiler.py said "Take optimization level from the configuration or 1 as default." This is incorrect - the default is 2. I have corrected the comment.

# Take optimization level from the configuration or 1 as default.

This fixes issue 14036:

#14036

@radams78 radams78 requested a review from a team as a code owner March 18, 2025 12:17
@qiskit-bot qiskit-bot added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Mar 18, 2025
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@CLAassistant
Copy link

CLAassistant commented Mar 18, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@alexanderivrii alexanderivrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@jakelishman jakelishman disabled auto-merge March 19, 2025 09:47
Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@radams78: thanks for the change. You'll need to sign the contributor-licensing agreement (see the bot's comment above) before we can accept this for merge.

(Strictly, I imagine that this commit isn't material to IP right assignment, but good luck teaching a bot that...)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13922990398

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.01%) to 88.074%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 3 91.73%
crates/qasm2/src/parse.rs 6 97.61%
Totals Coverage Status
Change from base Build 13920468265: 0.01%
Covered Lines: 72591
Relevant Lines: 82420

💛 - Coveralls

@radams78
Copy link
Contributor Author

Strange - I've agreed to the CLA but it still says 'not signed yet' here. Clicking 'recheck' here doesn't change that.
Screenshot from 2025-03-19 11-15-14

@jakelishman
Copy link
Member

No worries - I can see you've signed it in the CLA admin panel, so I've kicked the bot to have another look at the PR. Sometimes it gets a bit stuck - I'll give it an hour or so and hopefully it'll sort itself out.

@jakelishman
Copy link
Member

jakelishman commented Mar 19, 2025

@radams78: ah, I see the problem on closer inspection. You made the commit in this PR with an email that's not associated with your @radams78 account, but actually @robin-test-stack. You'll either need to sign the CLA with that account to make the bot happy, or you need to force-push over this branch with a new commit that's associated with an email address attached to @radams78 (I'm assuming of course that you made the first commit - if it was somebody else, they need to sign the CLA).

(edit: or reassign the email addresses in GitHub if your intent is to have your chalmers.se email associated with @radams78)

@robin-test-stack
Copy link
Contributor

Sorry about that. Done now. (How much work can it be to change one character in a comment?)

@jakelishman jakelishman added this pull request to the merge queue Mar 21, 2025
@jakelishman
Copy link
Member

Ha, sorry that was a bit of a faff. Thanks for coming back to it.

On the plus side, at least it shouldn't be a problem again if you use either account, and that should go for any Qiskit repo - the bot aggregates license signings on any Qiskit repo that uses the CLA (which tbf is probably all of them).

Merged via the queue into Qiskit:main with commit a88ed60 Mar 21, 2025
21 checks passed
@eliarbel eliarbel added the Changelog: None Do not include in changelog label Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog Community PR PRs from contributors that are not 'members' of the Qiskit repo
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

8 participants