Skip to content

Remove: Unnecessary py tokens in InstructionProperties. #13993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2025
Merged

Remove: Unnecessary py tokens in InstructionProperties. #13993

merged 1 commit into from
Mar 11, 2025

Conversation

raynelfss
Copy link
Contributor

Summary

The following PR removes some leftover py tokens from a couple of InstructionProperties methods in Rust.

Details and comments

@raynelfss raynelfss requested a review from a team as a code owner March 11, 2025 15:18
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13791669987

Details

  • 1 of 3 (33.33%) changed or added relevant lines in 1 file are covered.
  • 21 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.02%) to 88.131%
Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/accelerate/src/target_transpiler/instruction_properties.rs 1 3 33.33%
Files with Coverage Reduction New Missed Lines %
crates/accelerate/src/unitary_synthesis.rs 2 94.59%
crates/qasm2/src/lex.rs 7 92.23%
crates/qasm2/src/parse.rs 12 97.15%
Totals Coverage Status
Change from base Build 13773925054: -0.02%
Covered Lines: 72637
Relevant Lines: 82419
💛 - Coveralls

mtreinish
mtreinish approved these changes Mar 11, 2025
View reviewed changes
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems straightforward enough

@mtreinish mtreinish added this pull request to the merge queue Mar 11, 2025
@mtreinish mtreinish added Changelog: None Do not include in changelog Rust This PR or issue is related to Rust code in the repository labels Mar 11, 2025
Merged via the queue into Qiskit:main with commit 6107686 Mar 11, 2025
21 checks passed
raynelfss added a commit to raynelfss/qiskit that referenced this pull request Mar 20, 2025
@raynelfss
Remove: Unnecessary py tokens in InstructionProperties. (Qiskit#1…
d03a20c 
…3993)
@raynelfss raynelfss mentioned this pull request Mar 20, 2025
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtreinish mtreinish mtreinish approved these changes

Assignees
No one assigned
Labels
Changelog: None Do not include in changelog Rust This PR or issue is related to Rust code in the repository
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@raynelfss @qiskit-bot @coveralls @mtreinish