-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Fix barrier label when output='mpl' #13971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix barrier label when output='mpl' #13971
Conversation
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 15516940949Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
@jakelishman @nonhermitian could you please take a look at this? Any further changes required? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi - sorry this fell through the cracks. The base changeset looks sensible, but please could you add a test and a release note?
Also: could you check if this works sensibly when the user passes something to the wire_map
argument that causes a different ordering of qubits, other than simple inversion? (If that turns out to require much deeper changes, we can merge as-is and then follow up with that additional feature request.)
Hey folks! Thanks so much for your work on this. I tried out the I tried
It generates the barrier labels in the correct positions for each ordering. Thanks again! Looking forward to seeing this in the release. You rock! |
Summary
Fixes #13609
Changed the way the barrier label is applied to qubits.
Details and comments
PR-13780 resolved the issue for output=text, but the labels remained incorrectly placed when output=mpl.