Fix performance regression in circuit_to_instruction #13942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Qiskit#13921 a check was added to circuit_to_instruction() for determining if the circuit has a control flow op. This check was adding significant overhead to the function, nightly asv benchmarks are showing up to a ~9x slowdown. Qiskit#13921 attempted to fix this regression but did so by adding a new API which isn't applicable at this point for 2.0. That PR could/should still be used in 2.1. In the meantime this commit seeks to solve the performance regression by adjusting how the check is performed to mitigate the runtime regression for 2.0.
|
One or more of the following people are relevant to this code:
|
|
I ran some benchmarks locally on my laptop to test the performance improvement here: I did try using |
Pull Request Test Coverage Report for Build 13610021201Details
💛 - Coveralls |
|
How does the performance compare to before the original PR? |
There's still a regression, but it's less severe: |
jakelishman
approved these changes
Mar 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #13921 a check was added to circuit_to_instruction() for determining if the circuit has a control flow op. This check was adding significant overhead to the function, nightly asv benchmarks are showing up to a ~9x slowdown. #13921 attempted to fix this regression but did so by adding a new API which isn't applicable at this point for 2.0. That PR could/should still be used in 2.1. In the meantime this commit seeks to solve the performance regression by adjusting how the check is performed to mitigate the runtime regression for 2.0.
Details and comments