Restore HAS_TWEEDLEDUM optional checker #13940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Qiskit#13815 the usage of the tweedledum library was removed from Qiskit. The classes that used this functionality was deprecated in 1.4.0, but the optional library checker was not deprecated. These optionals checkers are part of the public API and would have needed a deprecation before removal as there may be downstream users of the checker. This commit restores the checker, but alters the docstring to make it clear that tweedledum isn't used by Qiskit anymore. If we want to remove the checker in 3.0 we can deprecate it in 2.1.0 or another release in the 2.x series. Although, there is basically no real cost for keeping it around so it's probably not worth the effort.
|
One or more of the following people are relevant to this code:
|
jakelishman
approved these changes
Mar 1, 2025
Pull Request Test Coverage Report for Build 13607367731Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #13815 the usage of the tweedledum library was removed from Qiskit. The classes that used this functionality was deprecated in 1.4.0, but the optional library checker was not deprecated. These optionals checkers are part of the public API and would have needed a deprecation before removal as there may be downstream users of the checker. This commit restores the checker, but alters the docstring to make it clear that tweedledum isn't used by Qiskit anymore. If we want to remove the checker in 3.0 we can deprecate it in 2.1.0 or another release in the 2.x series. Although, there is basically no real cost for keeping it around so it's probably not worth the effort.
Details and comments