Skip to content

Conversation

jakelishman
Copy link
Member

These were never really meant to be public at all, and we didn't even notice they existed publicly til we rewrote the QuantumCircuit documentation.

Summary

Details and comments

Part of #13699.

These were never really meant to be public at all, and we didn't even
notice they existed publicly til we rewrote the `QuantumCircuit`
documentation.
@jakelishman jakelishman added Changelog: API Change Include in the "Changed" section of the changelog mod: circuit Related to the core of the `QuantumCircuit` class or the circuit library labels Feb 19, 2025
@jakelishman jakelishman added this to the 2.0.0 milestone Feb 19, 2025
@jakelishman jakelishman requested a review from a team as a code owner February 19, 2025 18:26
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13419711675

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.009%) to 88.11%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 4 92.73%
Totals Coverage Status
Change from base Build 13411473274: 0.009%
Covered Lines: 78338
Relevant Lines: 88909

💛 - Coveralls

Copy link
Member

@alexanderivrii alexanderivrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks pretty straightforward. I guess the other two QuantumCircuit functions unit and duration that should be removed for 2.0 would be removed as a part of a different PR.

@alexanderivrii alexanderivrii added this pull request to the merge queue Feb 20, 2025
Merged via the queue into Qiskit:main with commit 589b338 Feb 20, 2025
18 checks passed
@jakelishman jakelishman deleted the remove-circuit-cruft branch February 20, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: API Change Include in the "Changed" section of the changelog mod: circuit Related to the core of the `QuantumCircuit` class or the circuit library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants