Skip to content

Change the register name for measure_active to meas #13866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 18, 2025
Merged

Change the register name for measure_active to meas #13866

merged 3 commits into from
Feb 18, 2025

Conversation

1ucian0
Copy link
Member

@1ucian0 1ucian0 commented Feb 17, 2025

Summary

Closes #12345

Details and comments

The method QuantumCircuit.measure_active() has changed the name of the classical register it creates, as the previous name conflicted with an OpenQASM reserved word. Instead of measure, it is now called meas, aligning with the register name used by QuantumCircuit.measure_all().

@1ucian0 1ucian0 added this to the 2.0.0 milestone Feb 17, 2025
@1ucian0 1ucian0 requested a review from a team as a code owner February 17, 2025 22:54
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@1ucian0 1ucian0 assigned 1ucian0 and unassigned 1ucian0 Feb 17, 2025
@coveralls
Copy link

coveralls commented Feb 18, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13387561265

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 14 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.002%) to 88.182%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 4 92.48%
qiskit/circuit/quantumcircuit.py 4 93.32%
crates/qasm2/src/parse.rs 6 97.15%
Totals Coverage Status
Change from base Build 13376164595: 0.002%
Covered Lines: 78738
Relevant Lines: 89290
💛 - Coveralls

jakelishman
jakelishman reviewed Feb 18, 2025
View reviewed changes
jakelishman
jakelishman approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small change, but it does feel better to make this across a major-version boundary, and I think it's a quality-of-life improvement.

@jakelishman jakelishman added this pull request to the merge queue Feb 18, 2025
Merged via the queue into Qiskit:main with commit 2d389e0 Feb 18, 2025
17 checks passed
@1ucian0 1ucian0 deleted the fixes/12345/1 branch February 18, 2025 13:30
@jakelishman jakelishman mentioned this pull request Feb 20, 2025
Closed
@ElePT ElePT added the Changelog: API Change Include in the "Changed" section of the changelog label Mar 31, 2025
@HarizZaman HarizZaman mentioned this pull request Apr 17, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakelishman jakelishman jakelishman approved these changes

@nonhermitian nonhermitian Awaiting requested review from nonhermitian

Assignees
No one assigned
Labels
Changelog: API Change Include in the "Changed" section of the changelog
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

measure_active returns register called "measure" which breaks round tripping in QASM
5 participants
@1ucian0 @qiskit-bot @coveralls @jakelishman @ElePT