Skip to content

Remove assemble and assembler module #13748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 5, 2025
Merged

Remove assemble and assembler module #13748

merged 5 commits into from
Feb 5, 2025

Conversation

ElePT
Copy link
Contributor

@ElePT ElePT commented Jan 28, 2025 •
edited
Loading

Summary

This PR removes the deprecated functionality related to assemble, which includes the following public API components:

  * ``qiskit.compiler.assemble`` function
  * ``qiskit.assembler.assemble_circuits`` function
  * ``qiskit.assembler.assemble_schedules`` function
  * ``qiskit.assembler.disassemble`` function
  * ``qiskit.assembler.RunConfig`` class
  * ``qiskit.circuit.Instruction.assemble`` method

Details and comments

This PR was developed on top of the changes from #13743 and is blocked by it.

@ElePT ElePT added the Changelog: Removal Include in the Removed section of the changelog label Jan 28, 2025
@ElePT ElePT mentioned this pull request Jan 28, 2025
Closed
@ElePT ElePT marked this pull request as ready for review January 28, 2025 12:47
@ElePT ElePT requested review from jyu00 and a team as code owners January 28, 2025 12:47
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@ElePT ElePT added this to the 2.0.0 milestone Jan 28, 2025
@coveralls
Copy link

coveralls commented Jan 28, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13138529136

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 124 unchanged lines in 13 files lost coverage.
  • Overall coverage decreased (-0.2%) to 88.654%
Files with Coverage Reduction New Missed Lines %
crates/circuit/src/dag_circuit.rs 1 89.36%
crates/accelerate/src/unitary_synthesis.rs 1 92.97%
qiskit/providers/fake_provider/fake_backend.py 1 85.51%
qiskit/circuit/quantumcircuit.py 1 93.63%
qiskit/pulse/transforms/canonicalization.py 1 93.44%
qiskit/pulse/transforms/base_transforms.py 2 86.96%
qiskit/pulse/schedule.py 3 88.6%
crates/qasm2/src/lex.rs 5 92.23%
qiskit/qobj/converters/lo_config.py 6 89.66%
qiskit/qobj/pulse_qobj.py 12 81.01%
Totals Coverage Status
Change from base Build 13135899673: -0.2%
Covered Lines: 78949
Relevant Lines: 89053
💛 - Coveralls

@eliarbel eliarbel assigned eliarbel and unassigned eliarbel Jan 30, 2025
@1ucian0 1ucian0 added the on hold Can not fix yet label Feb 3, 2025
@1ucian0
Copy link
Member

1ucian0 commented Feb 3, 2025

on hold until #13743 merges.

@1ucian0 1ucian0 mentioned this pull request Feb 3, 2025
Merged
2 tasks
eliarbel
eliarbel previously approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@eliarbel eliarbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a few minor reno suggestions but other than those this looks good to me.

@ElePT ElePT force-pushed the actually-remove-assemble branch from 2b8ce7d to 9d39869 Compare February 4, 2025 15:07
@ElePT ElePT removed the on hold Can not fix yet label Feb 4, 2025
@ElePT ElePT requested a review from eliarbel February 4, 2025 16:31
eliarbel
eliarbel approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@eliarbel eliarbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning the world!

@eliarbel eliarbel added this pull request to the merge queue Feb 5, 2025
Merged via the queue into Qiskit:main with commit 69bb439 Feb 5, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliarbel eliarbel eliarbel approved these changes

@jyu00 jyu00 Awaiting requested review from jyu00

Assignees

@eliarbel eliarbel

@ElePT ElePT

Labels
Changelog: Removal Include in the Removed section of the changelog
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ElePT @qiskit-bot @coveralls @1ucian0 @eliarbel