Move PendingDeprecations to Deprecations in the circuit library #13604

1ucian0 · 2024-12-24T16:12:30Z

Summary

The circuit library modernization from #13046 introduced some pending deprecations that this PR is moving to deprecations.

~~reno is still missing.~~

Cryoris · 2025-02-07T15:24:05Z

We could just have a single reno for the deprecation of BlueprintCircuit and mention the deprecation of all subclasses therein. That would be a bit cleaner for the users than having multiple 🙂

Cryoris

Thanks for taking care of this, this LGTM but it seems to only miss the catches in the tests 🙂

…3241/1

1ucian0 · 2025-02-20T14:22:09Z

Most of the problems are coming from an internal call to a deprecated method:

qiskit/circuit/library/standard_gates/x.py", line 1148, in __init__
    num_ancilla_qubits = self.__class__.get_num_ancilla_qubits(num_ctrl_qubits)
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

There is also some issues with BlueprintCircuit subclasses. From @Cryoris :

There's currently 5 subclasses:
QFT and NLocal are already deprecated
all others should be taken care of by #13371

Still working on the rest.

…to followup/13241/1

…r.test_cnot

alexanderivrii

Thanks for all the hard work, the PR is in a very good shape.

The most important comment for 2.1: should we also deprecate the following quantum circuits (all of which have gate equivalents):ExactReciprocal, LinearAmplitudeFunction, QuantumVolume, PhaseOracle, GR, GRX, GRY, GRZ?

Less important for now (and can be done in a follow-up): we should update the the docstrings for the classes PiecewisePolynomialPauliRotationsGate, zz_feature_map, z_feature_map (they refer to the quantum circuits that are being deprecated).

Less important for now (and should be done in a follow-up): multiple tests need to be updated to check gates/functions and not quantum circuits.

qiskit/circuit/library/boolean_logic/quantum_or.py

qiskit/circuit/quantumcircuit.py

…bbf5179d7604ef608aed6#r2106219162

ShellyGarion · 2025-05-27T08:51:52Z

I think that there are some circuit library circuits that should be deprecated but were still not pending deprecated. Do you think it could be part of this PR?

alexanderivrii · 2025-05-27T08:57:03Z

@ShellyGarion: these classes are already marked for deprecation in this PR -- they inherit from Adder or Multiplier classes that are being explicitly deprecated. In other words, if you instantiate an instance of DraperQFTAdder, it will call the parent's __init__ method and you will get the deprecation message.

alexanderivrii

Thanks again for working on this, Luciano and Julien. We have decided to leave the additional deprecations mentioned in #13604 (review) for a follow-up, so this is off to the merge queue.

…it#13604) * blueprint deprecation + reno * unittest test.python.transpiler.test_star_prerouting * test.python.transpiler.test_solovay_kitaev * test.python.transpiler.test_linear_functions_passes * unittest test.python.synthesis.test_qft_synthesis * test.python.synthesis.test_cz_synthesis * test.python.transpiler.test_parameterizedgate_translator * test.python.quantum_info.operators.test_operator * test.python.primitives.test_statevector_sampler * test.python.primitives.test_sampler * test.python.primitives.test_statevector_estimator * test.python.primitives.test_estimator * test.python.primitives.test_backend_sampler_v2 * test.python.primitives.test_backend_sampler * test.python.primitives.test_backend_estimator_v2 * test.python.primitives.test_backend_estimator * test.python.circuit.library.test_blueprintcircuit * test.python.transpiler.test_high_level_synthesis.TestHighLevelSynthesisModifiers.test_circuit_with_mcx * test.python.circuit.test_controlled_gate.TestControlledGate.test_mcxrecursive_clean_ancilla_cx_count * some less errors * capture the deprecations for internal usage * test.python.visualization.test_circuit_text_drawer.TestTextOpenControlledGate * test.python.circuit.library.test_boolean_logic * test.python.transpiler.test_swap_strategy_router * test.python.transpiler.test_high_level_synthesis * test.python.circuit.library.test_qft.TestQFT * test.python.circuit.test_controlled_gate.TestControlledGate * test.python.circuit.test_controlled_gate.TestControlledGate.test_mcxvchain_dirty_ancilla_action_only * test.python.circuit.test_controlled_gate.TestControlledGate * test.python.transpiler.test_high_level_synthesis * test.python.qasm2.test_export * EvolvedOperatorAnsatz * fix tests in circuit library * more controlled gate fixes * I can see light at the end of the tunnel * updating to 2.1 * black * filterwarnings * filterwarnings * last update of a since * pylint * test.python.circuit.library * Fix mcry and gray code deprecation msg * test.python.circuit.test_controlled_gate.TestControlledGate * test.python.circuit.test_controlled_gate.TestControlledStandardGates * qiskit/circuit/library/standard_gates/x.py:1533 * mpl.circuit.test_circuit_matplotlib_drawer.TestCircuitMatplotlibDrawer.test_cnot * https://github.com/Qiskit/qiskit/pull/13604/files/395658b3fbf603a7272bbf5179d7604ef608aed6#r2106219162 * addressing Qiskit#13604 (comment) --------- Co-authored-by: Julien Gacon <jules.gacon@googlemail.com>

1ucian0 mentioned this pull request Dec 25, 2024

Deprecate in 1.4 the pending deprecations from the 1.* cycle #13589

Closed

40 tasks

1ucian0 linked an issue Feb 4, 2025 that may be closed by this pull request

Deprecate in 1.4 the pending deprecations from the 1.* cycle #13589

Closed

40 tasks

Cryoris reviewed Feb 7, 2025

View reviewed changes

a76ebc7

1ucian0 force-pushed the followup/13241/1 branch from 4eee40c to a76ebc7 Compare February 10, 2025 13:18

1ucian0 changed the base branch from stable/1.4 to main February 10, 2025 13:19

Cryoris and others added 18 commits February 10, 2025 17:43

blueprint deprecation + reno

5c1420b

Merge branch 'main' into followup/13241/1

6db06ef

Merge branch 'main' of github.com:Qiskit/qiskit-terra into followup/1…

4d30309

…3241/1

unittest test.python.transpiler.test_star_prerouting

8418359

test.python.transpiler.test_solovay_kitaev

a614735

test.python.transpiler.test_linear_functions_passes

fd394dd

unittest test.python.synthesis.test_qft_synthesis

b848848

test.python.synthesis.test_cz_synthesis

4257e03

test.python.transpiler.test_parameterizedgate_translator

c5e7000

test.python.quantum_info.operators.test_operator

3f1e59a

test.python.primitives.test_statevector_sampler

cfac75b

test.python.primitives.test_sampler

6a11a16

test.python.primitives.test_statevector_estimator

f2f65d4

test.python.primitives.test_estimator

9bdad15

test.python.primitives.test_backend_sampler_v2

e80b209

test.python.primitives.test_backend_sampler

d094e95

test.python.primitives.test_backend_estimator_v2

677a6db

test.python.primitives.test_backend_estimator

6267f71

1ucian0 linked an issue Feb 15, 2025 that may be closed by this pull request

Deprecate BlueprintCircuit in 2.0 #13760

Closed

1ucian0 self-assigned this Feb 20, 2025

1ucian0 added this to the 2.0.0 milestone Feb 20, 2025

1ucian0 added the on hold Can not fix yet label Feb 20, 2025

1ucian0 and others added 12 commits May 21, 2025 12:01

Merge branch 'main' into followup/13241/1

0117e33

updating to 2.1

f167e64

black

dc31e76

filterwarnings

2ae4e53

filterwarnings

587c74b

last update of a since

9621a4a

pylint

e4a6ad3

test.python.circuit.library

471fc9c

conflict

a6fb4c0

Fix mcry and gray code deprecation msg

1db6bb9

test.python.circuit.test_controlled_gate.TestControlledGate

a120f94

Merge branch 'followup/13241/1' of github.com:1ucian0/qiskit-terra in…

c6a8fc6

…to followup/13241/1

eliarbel assigned alexanderivrii May 22, 2025

1ucian0 added 3 commits May 22, 2025 23:49

test.python.circuit.test_controlled_gate.TestControlledStandardGates

8f1a41f

qiskit/circuit/library/standard_gates/x.py:1533

d90ee47

mpl.circuit.test_circuit_matplotlib_drawer.TestCircuitMatplotlibDrawe…

395658b

…r.test_cnot

alexanderivrii reviewed May 25, 2025

View reviewed changes

qiskit/circuit/library/boolean_logic/quantum_or.py Outdated Show resolved Hide resolved

qiskit/circuit/quantumcircuit.py Outdated Show resolved Hide resolved

qiskit/circuit/quantumcircuit.py Outdated Show resolved Hide resolved

1ucian0 and others added 3 commits May 26, 2025 11:24

Merge branch 'main' into followup/13241/1

68cf5bb

https://github.com/Qiskit/qiskit/pull/13604/files/395658b3fbf603a7272…

3bcf771

…bbf5179d7604ef608aed6#r2106219162

addressing Qiskit#13604 (comment)

a1d1ef5

alexanderivrii approved these changes May 28, 2025

View reviewed changes

alexanderivrii added this pull request to the merge queue May 28, 2025

alexanderivrii mentioned this pull request May 28, 2025

Remaining circuit library deprecations #14478

Closed

Merged via the queue into Qiskit:main with commit 7b0c1d6 May 28, 2025
26 checks passed

AsadullahGalib007 mentioned this pull request May 30, 2025

Deprecate Remaining Legacy Circuit Library Classes and Update References #14511

Merged

eliarbel added the Changelog: Deprecation Include in "Deprecated" section of changelog label Jun 3, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Move PendingDeprecations to Deprecations in the circuit library #13604

Move PendingDeprecations to Deprecations in the circuit library #13604

Uh oh!

1ucian0 commented Dec 24, 2024 •

edited

Loading

Uh oh!

Cryoris commented Feb 7, 2025

Uh oh!

Cryoris left a comment

Uh oh!

1ucian0 commented Feb 20, 2025

Uh oh!

alexanderivrii left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ShellyGarion commented May 27, 2025

Uh oh!

alexanderivrii commented May 27, 2025

Uh oh!

alexanderivrii left a comment

Uh oh!

Uh oh!

Uh oh!

Move PendingDeprecations to Deprecations in the circuit library #13604

Move PendingDeprecations to Deprecations in the circuit library #13604

Uh oh!

Conversation

1ucian0 commented Dec 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

Cryoris commented Feb 7, 2025

Uh oh!

Cryoris left a comment

Choose a reason for hiding this comment

Uh oh!

1ucian0 commented Feb 20, 2025

Uh oh!

alexanderivrii left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ShellyGarion commented May 27, 2025

Uh oh!

alexanderivrii commented May 27, 2025

Uh oh!

alexanderivrii left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

1ucian0 commented Dec 24, 2024 •

edited

Loading