Deprecate 2-argument callable for atomic_evolution parameter
#13603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One or more of the following people are relevant to this code:
|
40 tasks
|
The failing builds are no longer available, but maybe there's still a test using the deprecated signature, causing the CI to fail 🤔 |
40 tasks
|
Broken CI reminder! The button to update branch seems to have disappeared? But I would recommend doing so to assess the state of the PR :) |
|
test updated. |
ElePT
approved these changes
Feb 17, 2025
|
+1 for remove since I don't believe this is used much and it would simplify our lives 🙂 |
|
Alright. I added an issue to the 2.0 milestone to make sure we don't forget to do it. |
atomic_evolutionatomic_evolution parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Following up #12724, the
PendingDeprecationWarningthere are now moved toDeprecationWarningDetails and comments
The argument
atomic_evolutionin the constructor for the classesLieTrotter,ProductFormula, andSuzukiTrotteris a callable with a different signature now: fromCallable[[Pauli | SparsePauliOp, float], QuantumCircuit]toCallable[[QuantumCircuit, Pauli | SparsePauliOp, float], None].